Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(calendar): add onMonthTitleClick #758

Merged
merged 7 commits into from
Jul 25, 2023

Conversation

A6lock
Copy link
Contributor

@A6lock A6lock commented Jul 21, 2023

Опишите проблему

Необходимо в мобильном приложении отлавливать клик на месяц, чтобы была возможность выбрать месяц, на который нажал пользователь.

Ожидаемое поведение

При нажатии на тайтл месяца в мобильном приложении должен вызываться колбэк.

@changeset-bot
Copy link

changeset-bot bot commented Jul 21, 2023

🦋 Changeset detected

Latest commit: b34f383

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@alfalab/core-components-calendar Minor
@alfalab/core-components-calendar-input Patch
@alfalab/core-components-calendar-range Patch
@alfalab/core-components-calendar-with-skeleton Patch
@alfalab/core-components-date-range-input Patch
@alfalab/core-components-date-time-input Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link

coveralls commented Jul 21, 2023

Pull Request Test Coverage Report for Build 5621069143

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 79.658%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/calendar/src/components/calendar-mobile/Component.tsx 0 2 0.0%
Totals Coverage Status
Change from base Build 5610938754: -0.02%
Covered Lines: 8123
Relevant Lines: 9226

💛 - Coveralls

@A6lock A6lock changed the title Feat/mobile calendar month title click feat(calendar): add onMonthTitleClick Jul 21, 2023
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

return (
<div className={styles.daysTable} id={`month-${index}`}>
{onMonthTitleClick ? (
activeMonthsTitle
Copy link
Contributor

@v-gevak v-gevak Jul 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Предлагаю без переменной сделать, так как в 99% случаев она будет бесполезной.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Готово

"@alfalab/core-components-calendar": minor
---

Добавлен проп onMonthTitleClick
Copy link
Contributor

@v-gevak v-gevak Jul 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Добавь что в CalendarMobile

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Готово

@A6lock A6lock requested a review from v-gevak July 21, 2023 10:05
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@Lewsha02 Lewsha02 self-requested a review July 25, 2023 12:58
@v-gevak v-gevak merged commit 6d3bf1e into master Jul 25, 2023
8 checks passed
@v-gevak v-gevak deleted the feat/mobile-calendar-month-title-click branch July 25, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants