Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(markdown): added component Markdown #767

Merged
merged 19 commits into from
Aug 9, 2023
Merged

feat(markdown): added component Markdown #767

merged 19 commits into from
Aug 9, 2023

Conversation

temss-front
Copy link
Contributor

Добавлен компонент Markdown

@changeset-bot
Copy link

changeset-bot bot commented Jul 27, 2023 •
edited

🦋 Changeset detected

Latest commit: 35f4a78

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@alfalab/core-components-markdown Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link

coveralls commented Jul 27, 2023 •
edited

Pull Request Test Coverage Report for Build 5749929536

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 52 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.06%) to 79.601%
Files with Coverage Reduction New Missed Lines %
packages/calendar-input/src/components/calendar-input/Component.tsx 4 89.51%
packages/date-time-input/src/components/date-time-input/Component.tsx 12 77.92%
packages/intl-phone-input/src/component.tsx 14 78.41%
packages/date-range-input/src/components/date-range-input/Component.tsx 22 72.83%
Totals Coverage Status
Change from base Build 5676844918: -0.06%
Covered Lines: 8145
Relevant Lines: 9251
💛 - Coveralls

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds core-ds deleted a comment from core-ds-bot Jul 31, 2023
@core-ds core-ds deleted a comment from core-ds-bot Jul 31, 2023
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

Valeri8888
Valeri8888 reviewed Aug 1, 2023
View reviewed changes
packages/markdown/package.json Outdated
"main": "index.js",
"license": "MIT",
"scripts": {
"postinstall": "node -e \"if (require('fs').existsSync('./send-stats.js')){require('./send-stats.js')} \""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

удали плиз postinstall мы выпиливаем его

v-gevak
v-gevak reviewed Aug 3, 2023
View reviewed changes
packages/markdown/src/docs/development.mdx Outdated
```jsx
import { Markdown } from '@alfalab/core-components/markdown';
import { MarkdownMobile } from '@alfalab/core-components/markdown';
import { MarkdownDesktop } from '@alfalab/core-components/markdown';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/desktop на конце должно быть и /mobile соответственно

v-gevak
v-gevak reviewed Aug 3, 2023
View reviewed changes
packages/markdown/src/index.ts Outdated
@@ -0,0 +1,4 @@
export { MarkdownResponsiveComponent as Markdown } from './Component.responsive';
export { MarkdownMobileComponent as MarkdownMobile } from './Component.mobile';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Экспорт из mobile.ts

v-gevak
v-gevak reviewed Aug 3, 2023
View reviewed changes
packages/markdown/src/index.ts Outdated
@@ -0,0 +1,4 @@
export { MarkdownResponsiveComponent as Markdown } from './Component.responsive';
export { MarkdownMobileComponent as MarkdownMobile } from './Component.mobile';
export { MarkdownDesktopComponent as MarkdownDesktop } from './Component.desktop';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Экспорт из desktop.ts

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

v-gevak
v-gevak suggested changes Aug 8, 2023
View reviewed changes
packages/markdown/src/mobile.ts Show resolved Hide resolved
packages/markdown/src/desktop.ts Show resolved Hide resolved
v-gevak
v-gevak reviewed Aug 8, 2023
View reviewed changes
packages/bank-card/src/Component.test.tsx Outdated
@@ -18,7 +18,7 @@ describe('BankCard', () => {
dispatchEvent: jest.fn(),
})),
});

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Лишник изменения, надо бы от них избавиться

@core-ds-bot
Copy link
Collaborator

core-ds-bot commented Aug 9, 2023 •
edited

Bundle size report

Entry point Size (minified)
markdown/desktop.js 118.93 (+118.93 KB🔺)
markdown/index.js 120.35 (+120.35 KB🔺)
markdown/mobile.js 118.93 (+118.93 KB🔺)

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@v-gevak v-gevak merged commit a1276f5 into master Aug 9, 2023
8 checks passed
@v-gevak v-gevak deleted the feat/markdown_component branch August 9, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SiebenSieben SiebenSieben SiebenSieben approved these changes

@v-gevak v-gevak v-gevak approved these changes

@Oladii Oladii Oladii approved these changes

@Valeri8888 Valeri8888 Valeri8888 approved these changes

@reme3d2y reme3d2y Awaiting requested review from reme3d2y reme3d2y is a code owner

@EGNKupava EGNKupava Awaiting requested review from EGNKupava

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@temss-front @coveralls @core-ds-bot @SiebenSieben @v-gevak @Oladii @Valeri8888