-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cdn-icon): added color icon support #778
Conversation
🦋 Changeset detectedLatest commit: db01fca The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Pull Request Test Coverage Report for Build 5760373486
💛 - Coveralls |
Собрана новая демка. |
@@ -6,6 +6,6 @@ | |||
.component svg { | |||
fill: currentColor; | |||
} | |||
.component path { | |||
.component.parentColor path { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Тут лучше убрать .component, оставить только .parentColor path {
changeset нужно добавить |
Собрана новая демка. |
Собрана новая демка. |
Опишите проблему
При name='flag_abkhazia_m_color' или любой другой цветной иконки с пометкой '_color' компонент возвращал черную иконку.
Шаги для воспроизведения
<CDNIcon name='flag_abkhazia_m_color' />
Ожидаемое поведение
При name='flag_abkhazia_m_color' или любой другой цветной иконки с пометкой '_color' компонент должен возвращать цветную иконку.
Внешний вид