Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(system-message): added padding prop #790

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

v-gevak
Copy link
Contributor

@v-gevak v-gevak commented Aug 11, 2023

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Aug 11, 2023

🦋 Changeset detected

Latest commit: 1510813

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 51 packages
Name Type
@alfalab/core-components-shared Minor
@alfalab/core-components-system-message Minor
@alfalab/core-components-action-button Patch
@alfalab/core-components-bottom-sheet Patch
@alfalab/core-components-button Patch
@alfalab/core-components-navigation-bar Patch
@alfalab/core-components-pass-code Patch
@alfalab/core-components-pattern-lock Patch
@alfalab/core-components-pure-cell Patch
@alfalab/core-components-select Patch
@alfalab/core-components-side-panel Patch
@alfalab/core-components-sortable-list Patch
@alfalab/core-components-tabs Patch
@alfalab/core-components-tooltip Patch
@alfalab/core-components-attach Patch
@alfalab/core-components-calendar Patch
@alfalab/core-components-confirmation-v1 Patch
@alfalab/core-components-confirmation Patch
@alfalab/core-components-custom-button Patch
@alfalab/core-components-icon-button Patch
@alfalab/core-components-input-autocomplete Patch
@alfalab/core-components-input Patch
@alfalab/core-components-picker-button Patch
@alfalab/core-components-plate Patch
@alfalab/core-components-table Patch
@alfalab/core-components-modal Patch
@alfalab/core-components-intl-phone-input Patch
@alfalab/core-components-select-with-tags Patch
@alfalab/core-components-gallery Patch
@alfalab/core-components-calendar-input Patch
@alfalab/core-components-calendar-range Patch
@alfalab/core-components-calendar-with-skeleton Patch
@alfalab/core-components-date-range-input Patch
@alfalab/core-components-date-time-input Patch
@alfalab/core-components-custom-picker-button Patch
@alfalab/core-components-file-upload-item Patch
@alfalab/core-components-password-input Patch
@alfalab/core-components-toast-plate Patch
@alfalab/core-components-amount-input Patch
@alfalab/core-components-date-input Patch
@alfalab/core-components-masked-input Patch
@alfalab/core-components-number-input Patch
@alfalab/core-components-slider-input Patch
@alfalab/core-components-time-input Patch
@alfalab/core-components-with-suffix Patch
@alfalab/core-components-alert Patch
@alfalab/core-components-notification Patch
@alfalab/core-components-toast Patch
@alfalab/core-components-bank-card Patch
@alfalab/core-components-phone-input Patch
@alfalab/core-components-notification-manager Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В ченджлоге только про десктопную версию, а влияет и на мобильную?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не, там про проп direction, про вертикальное/горизонтальное расположение кнопок.
А скрины обновлены из-за изменения порядка кнопок.

@v-gevak v-gevak force-pushed the feat/system-message-padding branch 2 times, most recently from 742141d to 4c171ec Compare August 15, 2023 04:51
@v-gevak v-gevak force-pushed the feat/system-message-padding branch from 4c171ec to 1510813 Compare August 15, 2023 05:04
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5863788479

  • 41 of 42 (97.62%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 82.876%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/shared/src/createPaddingStyle.ts 3 4 75.0%
Totals Coverage Status
Change from base Build 5855701843: 0.006%
Covered Lines: 7784
Relevant Lines: 8650

💛 - Coveralls

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@v-gevak v-gevak merged commit 6428280 into master Aug 15, 2023
8 checks passed
@v-gevak v-gevak deleted the feat/system-message-padding branch August 15, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants