feat(popup-sheet): new component #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-gevak
requested review from
reme3d2y,
EGNKupava and
SiebenSieben
as code owners
🦋 Changeset detectedLatest commit: ceaceb5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 55 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Bundle size report
|
v-gevak
force-pushed
the
feat/popup-sheet
branch
3 times, most recently
from
aade73c
to
281ce69
Compare
|
Собрана новая демка. |
|
Тут нет лишнего отступа сверху? |
SiebenSieben
approved these changes
Aug 16, 2023
По макетам делал - https://www.figma.com/file/MqpSYcvpzj0NG58uLTGJKK/Web-%3A%3A-Storybook-Docs?type=design&node-id=3703-44051&mode=design&t=TuU8WSdxOwXW55s9-0 |
v-gevak
force-pushed
the
feat/popup-sheet
branch
from
281ce69
to
5c3a6b0
Compare
|
Собрана новая демка. |
Oladii
approved these changes
Aug 16, 2023
reme3d2y
reviewed
Aug 16, 2023
| margin: auto var(--gap-xs) var(--gap-xs); | ||
| width: calc(100% - 2 * var(--gap-xs)); | ||
| max-width: 600px; | ||
| border-radius: 36px; |
reme3d2y
reviewed
Aug 16, 2023
| } | ||
|
|
||
| .exitBySwipe { | ||
| transform: translateY(calc(100% + 100px)); |
There was a problem hiding this comment.
Не сразу понятно, что за 100px
reme3d2y
approved these changes
Aug 16, 2023
v-gevak
force-pushed
the
feat/popup-sheet
branch
from
5c3a6b0
to
005916c
Compare
v-gevak
force-pushed
the
feat/popup-sheet
branch
from
005916c
to
ceaceb5
Compare
|
Собрана новая демка. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.