Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(stepper-input): new component #817

Merged
merged 1 commit into from
Sep 1, 2023
Merged

feat(stepper-input): new component #817

merged 1 commit into from
Sep 1, 2023

Conversation

v-gevak
Copy link
Contributor

@v-gevak v-gevak commented Aug 24, 2023

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Aug 24, 2023 •
edited

🦋 Changeset detected

Latest commit: 388621c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 55 packages
Name Type
@alfalab/core-components-shared Minor
@alfalab/core-components-themes Minor
@alfalab/core-components-input Minor
@alfalab/core-components-stepper-input Major
@alfalab/core-components-number-input Minor
@alfalab/core-components-action-button Patch
@alfalab/core-components-bottom-sheet Patch
@alfalab/core-components-button Patch
@alfalab/core-components-markdown Patch
@alfalab/core-components-navigation-bar Patch
@alfalab/core-components-pass-code Patch
@alfalab/core-components-pattern-lock Patch
@alfalab/core-components-popup-sheet Patch
@alfalab/core-components-pure-cell Patch
@alfalab/core-components-select Patch
@alfalab/core-components-side-panel Patch
@alfalab/core-components-sortable-list Patch
@alfalab/core-components-system-message Patch
@alfalab/core-components-tabs Patch
@alfalab/core-components-amount-input Patch
@alfalab/core-components-date-input Patch
@alfalab/core-components-date-range-input Patch
@alfalab/core-components-date-time-input Patch
@alfalab/core-components-input-autocomplete Patch
@alfalab/core-components-masked-input Patch
@alfalab/core-components-password-input Patch
@alfalab/core-components-slider-input Patch
@alfalab/core-components-time-input Patch
@alfalab/core-components-with-suffix Patch
@alfalab/core-components-tooltip Patch
@alfalab/core-components-attach Patch
@alfalab/core-components-calendar Patch
@alfalab/core-components-confirmation-v1 Patch
@alfalab/core-components-confirmation Patch
@alfalab/core-components-custom-button Patch
@alfalab/core-components-icon-button Patch
@alfalab/core-components-picker-button Patch
@alfalab/core-components-plate Patch
@alfalab/core-components-table Patch
@alfalab/core-components-modal Patch
@alfalab/core-components-custom-picker-button Patch
@alfalab/core-components-intl-phone-input Patch
@alfalab/core-components-select-with-tags Patch
@alfalab/core-components-calendar-input Patch
@alfalab/core-components-calendar-range Patch
@alfalab/core-components-bank-card Patch
@alfalab/core-components-phone-input Patch
@alfalab/core-components-gallery Patch
@alfalab/core-components-calendar-with-skeleton Patch
@alfalab/core-components-file-upload-item Patch
@alfalab/core-components-toast-plate Patch
@alfalab/core-components-alert Patch
@alfalab/core-components-notification Patch
@alfalab/core-components-toast Patch
@alfalab/core-components-notification-manager Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@core-ds-bot
Copy link
Collaborator

core-ds-bot commented Aug 24, 2023 •
edited

Bundle size report

Entry point Size (minified)
number-input/desktop.js 18.56 (+18.56 KB🔺)
number-input/mobile.js 18.56 (+18.56 KB🔺)
stepper-input/desktop.js 22.79 (+22.79 KB🔺)
stepper-input/index.js 23.59 (+23.59 KB🔺)
stepper-input/mobile.js 22.78 (+22.78 KB🔺)

@core-ds core-ds deleted a comment from core-ds-bot Aug 25, 2023
@v-gevak v-gevak changed the title [WIP]feat(step-input): new component feat(step-input): new component Aug 25, 2023
@v-gevak v-gevak marked this pull request as ready for review August 25, 2023 10:29
@core-ds core-ds deleted a comment from core-ds-bot Aug 25, 2023
@v-gevak v-gevak force-pushed the feat/step_input branch 2 times, most recently from 61b182f to 0078c77 Compare August 28, 2023 05:39
@core-ds core-ds deleted a comment from core-ds-bot Aug 28, 2023
@core-ds core-ds deleted a comment from core-ds-bot Aug 28, 2023
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@reme3d2y
Copy link
Contributor

  • и - как-будто не имеют состояний :hover и :active, это так задумано?

@reme3d2y
Copy link
Contributor

image

@coveralls
Copy link

coveralls commented Aug 28, 2023 •
edited

Pull Request Test Coverage Report for Build 6024491803

  • 123 of 129 (95.35%) changed or added relevant lines in 11 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 82.744%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/shared/src/inputUtils.ts 5 6 83.33%
packages/stepper-input/src/components/steppers/Component.tsx 19 20 95.0%
packages/stepper-input/src/utils.ts 18 19 94.74%
packages/stepper-input/src/components/base-stepper-input/Component.tsx 56 59 94.92%
Totals Coverage Status
Change from base Build 6011877418: 0.1%
Covered Lines: 7953
Relevant Lines: 8845
💛 - Coveralls

@v-gevak
Copy link
Contributor Author

v-gevak commented Aug 28, 2023

  • и - как-будто не имеют состояний :hover и :active, это так задумано?

Исправил

@v-gevak
Copy link
Contributor Author

v-gevak commented Aug 28, 2023

image

Исправил

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

Oladii
Oladii approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@Oladii Oladii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

К демке вопросов нет, но пока не вливайте, возможно будут небольшие визуальные правки.

@SiebenSieben
Copy link
Contributor

В мобильной версии при фокусе не виден фон кнопок, это ок?
image

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@v-gevak v-gevak changed the title feat(step-input): new component feat(stepper-input): new component Aug 30, 2023
@v-gevak
Copy link
Contributor Author

v-gevak commented Aug 30, 2023

В мобильной версии при фокусе не виден фон кнопок, это ок? image

Баг FormControl, будем исправлять другой таской

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@v-gevak v-gevak merged commit c9b1a6a into master Sep 1, 2023
8 checks passed
@v-gevak v-gevak deleted the feat/step_input branch September 1, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SiebenSieben SiebenSieben SiebenSieben approved these changes

@reme3d2y reme3d2y reme3d2y approved these changes

@Oladii Oladii Oladii approved these changes

@EGNKupava EGNKupava Awaiting requested review from EGNKupava

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@v-gevak @core-ds-bot @reme3d2y @coveralls @SiebenSieben @Oladii