Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(select): refactoring #933

Merged
merged 1 commit into from
Nov 2, 2023
Merged

refactor(select): refactoring #933

merged 1 commit into from
Nov 2, 2023

Conversation

v-gevak
Copy link
Contributor

@v-gevak v-gevak commented Oct 23, 2023

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2023 •
edited

🦋 Changeset detected

Latest commit: 52fab7f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages
Name Type
@alfalab/core-components-base-modal Minor
@alfalab/core-components-tabs Minor
@alfalab/core-components-select Minor
@alfalab/core-components-bottom-sheet Patch
@alfalab/core-components-drawer Patch
@alfalab/core-components-gallery Patch
@alfalab/core-components-modal Patch
@alfalab/core-components-popup-sheet Patch
@alfalab/core-components-side-panel Patch
@alfalab/core-components-custom-picker-button Patch
@alfalab/core-components-input-autocomplete Patch
@alfalab/core-components-international-phone-input Patch
@alfalab/core-components-intl-phone-input Patch
@alfalab/core-components-picker-button Patch
@alfalab/core-components-select-with-tags Patch
@alfalab/core-components-table Patch
@alfalab/core-components-tooltip Patch
@alfalab/core-components-calendar Patch
@alfalab/core-components-calendar-input Patch
@alfalab/core-components-calendar-range Patch
@alfalab/core-components-calendar-with-skeleton Patch
@alfalab/core-components-date-range-input Patch
@alfalab/core-components-date-time-input Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@v-gevak v-gevak linked an issue Oct 23, 2023 that may be closed by this pull request
Добавить в SelectMobile isBottomSheet #924
Closed
2 tasks
@core-ds-bot
Copy link
Collaborator

core-ds-bot commented Oct 23, 2023 •
edited

Bundle size report

Entry point Size (minified)
tabs/collapsible.js 161.31 (-5.82 KB)
select/shared.js 124.46 (-38.61 KB)
select/index.js 201.21 (-4.16 KB)
select-with-tags/index.js 159.94 (-3.74 KB)
picker-button/desktop.js 154.23 (-5.82 KB)
picker-button/mobile.js 188.72 (-29.45 KB)
picker-button/index.js 214.95 (-4.49 KB)
international-phone-input/mobile.js 505.24 (-29.43 KB)
international-phone-input/index.js 531.87 (-5.02 KB)
input-autocomplete/index.js 214.27 (-4.49 KB)
custom-picker-button/desktop.js 155.69 (-5.83 KB)
custom-picker-button/mobile.js 190.18 (-29.44 KB)
custom-picker-button/index.js 216.03 (-5.05 KB)

@coveralls
Copy link

coveralls commented Oct 23, 2023 •
edited

Pull Request Test Coverage Report for Build 6675892007

  • 98 of 110 (89.09%) changed or added relevant lines in 11 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.5%) to 82.264%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/select/src/components/base-select/Component.tsx 68 80 85.0%
Files with Coverage Reduction New Missed Lines %
packages/select/src/components/base-select/Component.tsx 3 70.7%
Totals Coverage Status
Change from base Build 6675857723: 0.5%
Covered Lines: 8599
Relevant Lines: 9587
💛 - Coveralls

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

reme3d2y
reme3d2y reviewed Oct 23, 2023
View reviewed changes
Copy link
Contributor

@reme3d2y reme3d2y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Пока только код посмотрел

packages/select/src/components/base-select/Component.tsx Show resolved Hide resolved
@Valeri8888
Copy link
Collaborator

2023-10-27.10.14.41.mov

что-то странное происходит, при повторном клике прыгает наверх

@v-gevak
Copy link
Contributor Author

v-gevak commented Oct 27, 2023

что-то странное происходит, при повторном клике прыгает наверх

Исправил

@v-gevak v-gevak force-pushed the refactor/select branch 2 times, most recently from d62981a to 018d575 Compare October 28, 2023 08:41
@core-ds core-ds deleted a comment from core-ds-bot Oct 28, 2023
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@v-gevak v-gevak merged commit 3b1131c into master Nov 2, 2023
8 checks passed
@v-gevak v-gevak deleted the refactor/select branch November 2, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SiebenSieben SiebenSieben SiebenSieben approved these changes

@reme3d2y reme3d2y reme3d2y approved these changes

@Valeri8888 Valeri8888 Valeri8888 approved these changes

@EGNKupava EGNKupava Awaiting requested review from EGNKupava

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Добавить в SelectMobile isBottomSheet
6 participants
@v-gevak @core-ds-bot @coveralls @Valeri8888 @SiebenSieben @reme3d2y