Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy over the 63-bit restriction to YANG-CBOR, too (RW) #138

Closed
cabo opened this issue Jan 5, 2022 · 0 comments
Closed

Copy over the 63-bit restriction to YANG-CBOR, too (RW) #138

cabo opened this issue Jan 5, 2022 · 0 comments

Comments

@cabo
Copy link
Member

cabo commented Jan 5, 2022

The SID draft constraints SIDs to being 63 bits. Should that text/constraint move to the CBOR draft instead?

Strictly speaking, the YANG-CBOR specification does not have to make this constraint; deltas from 64-bit unsigned integers do fit into CBOR 64-bit+sign integers. However, given little compiler support for 64+sign, implementers are rather likely to get this wrong. More so, as the usual source of SIDs to be used with YANG-CBOR is constrained to 63-bit integers, as you note, so there will be little testing of SID deltas that don’t fit into int64.
We can defuse this situation, with no practical loss, by insisting on 63-bit unsigned integers for the SIDs in YANG-CBOR, too.

@cabo cabo closed this as completed in d3d7cfe Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant