Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump dompdf/dompdf version to 0.8 #4

Merged
merged 1 commit into from Jul 18, 2017
Merged

bump dompdf/dompdf version to 0.8 #4

merged 1 commit into from Jul 18, 2017

Conversation

84m
Copy link
Contributor

@84m 84m commented Jul 17, 2017

Because of dompdf/dompdf/issues/1272 i was trying to require the latest release of dompdf/dompdf, which is not possible because of "dompdf/dompdf": "^0.7" instead of `"dompdf/dompdf": "~0.7".
So i raised the required version of dompdf here :-)

composer.json Outdated
@@ -18,7 +18,7 @@
],
"require": {
"php": "^7.0",
"dompdf/dompdf": "^0.7",
"dompdf/dompdf": "^0.8",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please change this to ^0.7 || ^0.8 @84m

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of course @core23, just did so. Will you find some time to release a new version soon?

@nucleos nucleos deleted a comment from coveralls Jul 18, 2017
@nucleos nucleos deleted a comment from coveralls Jul 18, 2017
@nucleos nucleos deleted a comment from coveralls Jul 18, 2017
@nucleos nucleos deleted a comment from coveralls Jul 18, 2017
@nucleos nucleos deleted a comment from coveralls Jul 18, 2017
@nucleos nucleos deleted a comment from coveralls Jul 18, 2017
@nucleos nucleos deleted a comment from coveralls Jul 18, 2017
@nucleos nucleos deleted a comment from coveralls Jul 18, 2017
@core23 core23 merged commit c317f40 into nucleos:master Jul 18, 2017
@core23
Copy link
Member

core23 commented Jul 18, 2017

Thanks @84m

There are a lot of BC breaks since the last major. I plan to release a new major release by the end of the month.

@84m 84m deleted the patch-1 branch July 18, 2017 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants