Merge 2249977 into 7051570

nucleos · Jul 30, 2019 · 072012c · 072012c
2 parents 7051570 + 2249977
commit 072012c
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 3 deletions.
diff --git a/phpstan.neon b/phpstan.neon
@@ -13,4 +13,10 @@ parameters:
         # Symfony DI
         - '#Call to an undefined method Symfony\\Component\\Config\\Definition\\Builder\\NodeDefinition::children\(\).#'
         - '#Cannot call method end\(\) on Symfony\\Component\\Config\\Definition\\Builder\\NodeParentInterface\|null.#'
+        - "/Call to function method_exists.. with 'Symfony.+' and 'getRootNode' will always evaluate to false./"
+
+        # PHPUnit
+        -
+            message: '#Property .*::\$.* has no typehint specified.#'
+            path: tests/
 
diff --git a/tests/DependencyInjection/Compiler/SitemapCompilerPassTest.php b/tests/DependencyInjection/Compiler/SitemapCompilerPassTest.php
@@ -30,7 +30,7 @@ final class SitemapCompilerPassTest extends TestCase
      */
     private $container;
 
-    protected function setUp()
+    protected function setUp(): void
     {
         $this->serviceManager = $this->prophesize(Definition::class);
         $this->serviceManager->hasTag('core23.sitemap')

diff --git a/tests/Generator/SitemapGeneratorTest.php b/tests/Generator/SitemapGeneratorTest.php
@@ -35,7 +35,7 @@ public static function setUpBeforeClass()
         date_default_timezone_set('UTC');
     }
 
-    protected function setUp()
+    protected function setUp(): void
     {
         $this->sitemapServiceManager = $this->prophesize(SitemapServiceManagerInterface::class);
         $this->defintionManager      = $this->prophesize(DefintionManagerInterface::class);

diff --git a/vendor-bin/phpstan/composer.json b/vendor-bin/phpstan/composer.json
@@ -1,9 +1,12 @@
 {
     "require": {
+        "ekino/phpstan-banned-code": "^0.1",
         "jangregor/phpstan-prophecy": "^0.4",
         "phpstan/extension-installer": "^1.0",
         "phpstan/phpstan": "^0.11",
-        "phpstan/phpstan-phpunit": "^0.11"
+        "phpstan/phpstan-phpunit": "^0.11",
+        "phpstan/phpstan-strict-rules": "^0.11",
+        "phpstan/phpstan-symfony": "^0.11"
     },
     "conflict": {
         "phpunit/phpunit": ">=8.0"