Merge pull request #13 from core23/develop

[BUILD] Added more phpstan checks
nucleos · Jul 25, 2019 · fe6cda5 · fe6cda5
2 parents d5bd18c + 3ad544f
commit fe6cda5
Show file tree

Hide file tree

Showing 30 changed files with 6 additions and 478 deletions.
diff --git a/phpstan.neon b/phpstan.neon
@@ -1,7 +1,5 @@
 includes:
     - vendor-bin/phpstan/vendor/jangregor/phpstan-prophecy/src/extension.neon
-    - vendor-bin/phpstan/vendor/phpstan/phpstan-phpunit/extension.neon
-    - vendor-bin/phpstan/vendor/phpstan/phpstan-phpunit/rules.neon
 
 parameters:
     autoload_files:

diff --git a/src/Builder/ArtistSearchBuilder.php b/src/Builder/ArtistSearchBuilder.php
@@ -34,8 +34,6 @@ public static function create(): self
     }
 
     /**
-     * @param int $page
-     *
      * @return ArtistSearchBuilder
      */
     public function page(int $page): self
@@ -46,8 +44,6 @@ public function page(int $page): self
     }
 
     /**
-     * @param string $mode
-     *
      * @return ArtistSearchBuilder
      */
     public function sort(string $mode): self
@@ -62,8 +58,6 @@ public function sort(string $mode): self
     }
 
     /**
-     * @param string $name
-     *
      * @return ArtistSearchBuilder
      */
     public function withName(string $name): self
@@ -74,8 +68,6 @@ public function withName(string $name): self
     }
 
     /**
-     * @param string $mbid
-     *
      * @return ArtistSearchBuilder
      */
     public function withMbid(string $mbid): self
@@ -86,8 +78,6 @@ public function withMbid(string $mbid): self
     }
 
     /**
-     * @param int $tmid
-     *
      * @return ArtistSearchBuilder
      */
     public function withTmbid(int $tmid): self
@@ -97,9 +87,6 @@ public function withTmbid(int $tmid): self
         return $this;
     }
 
-    /**
-     * @return array
-     */
     public function getQuery(): array
     {
         return $this->query;

diff --git a/src/Builder/CitySearchBuilder.php b/src/Builder/CitySearchBuilder.php
@@ -32,8 +32,6 @@ public static function create(): self
     }
 
     /**
-     * @param int $page
-     *
      * @return CitySearchBuilder
      */
     public function page(int $page): self
@@ -44,8 +42,6 @@ public function page(int $page): self
     }
 
     /**
-     * @param string $name
-     *
      * @return CitySearchBuilder
      */
     public function withName(string $name): self
@@ -56,8 +52,6 @@ public function withName(string $name): self
     }
 
     /**
-     * @param string $country
-     *
      * @return CitySearchBuilder
      */
     public function withCountry(string $country): self
@@ -68,8 +62,6 @@ public function withCountry(string $country): self
     }
 
     /**
-     * @param string $name
-     *
      * @return CitySearchBuilder
      */
     public function withState(string $name): self
@@ -80,8 +72,6 @@ public function withState(string $name): self
     }
 
     /**
-     * @param string $code
-     *
      * @return CitySearchBuilder
      */
     public function withStateCode(string $code): self
@@ -91,9 +81,6 @@ public function withStateCode(string $code): self
         return $this;
     }
 
-    /**
-     * @return array
-     */
     public function getQuery(): array
     {
         return $this->query;

diff --git a/src/Builder/SetlistSearchBuilder.php b/src/Builder/SetlistSearchBuilder.php
@@ -34,8 +34,6 @@ public static function create(): self
     }
 
     /**
-     * @param int $page
-     *
      * @return SetlistSearchBuilder
      */
     public function page(int $page): self
@@ -46,8 +44,6 @@ public function page(int $page): self
     }
 
     /**
-     * @param string $name
-     *
      * @return SetlistSearchBuilder
      */
     public function withArtistName(string $name): self
@@ -58,8 +54,6 @@ public function withArtistName(string $name): self
     }
 
     /**
-     * @param string $mbid
-     *
      * @return SetlistSearchBuilder
      */
     public function withArtistMbid(string $mbid): self
@@ -70,8 +64,6 @@ public function withArtistMbid(string $mbid): self
     }
 
     /**
-     * @param int $tmid
-     *
      * @return SetlistSearchBuilder
      */
     public function withArtistTmbid(int $tmid): self
@@ -82,8 +74,6 @@ public function withArtistTmbid(int $tmid): self
     }
 
     /**
-     * @param string $name
-     *
      * @return SetlistSearchBuilder
      */
     public function withCity(string $name): self
@@ -94,8 +84,6 @@ public function withCity(string $name): self
     }
 
     /**
-     * @param int $id
-     *
      * @return SetlistSearchBuilder
      */
     public function withCityId(int $id): self
@@ -106,8 +94,6 @@ public function withCityId(int $id): self
     }
 
     /**
-     * @param string $code
-     *
      * @return SetlistSearchBuilder
      */
     public function withCountryCode(string $code): self
@@ -118,8 +104,6 @@ public function withCountryCode(string $code): self
     }
 
     /**
-     * @param DateTime $date
-     *
      * @return SetlistSearchBuilder
      */
     public function withDate(DateTime $date): self
@@ -130,8 +114,6 @@ public function withDate(DateTime $date): self
     }
 
     /**
-     * @param int $year
-     *
      * @return SetlistSearchBuilder
      */
     public function withYear(int $year): self
@@ -142,8 +124,6 @@ public function withYear(int $year): self
     }
 
     /**
-     * @param string $eventId
-     *
      * @return SetlistSearchBuilder
      *
      * @deprecated since setlist.fm API 1.0
@@ -156,8 +136,6 @@ public function withLastFm(string $eventId): self
     }
 
     /**
-     * @param DateTime $date
-     *
      * @return SetlistSearchBuilder
      */
     public function withLastUpdated(DateTime $date): self
@@ -168,8 +146,6 @@ public function withLastUpdated(DateTime $date): self
     }
 
     /**
-     * @param string $name
-     *
      * @return SetlistSearchBuilder
      */
     public function withState(string $name): self
@@ -180,8 +156,6 @@ public function withState(string $name): self
     }
 
     /**
-     * @param string $code
-     *
      * @return SetlistSearchBuilder
      */
     public function withStateCode(string $code): self
@@ -192,8 +166,6 @@ public function withStateCode(string $code): self
     }
 
     /**
-     * @param string $name
-     *
      * @return SetlistSearchBuilder
      */
     public function withTourName(string $name): self
@@ -204,8 +176,6 @@ public function withTourName(string $name): self
     }
 
     /**
-     * @param string $name
-     *
      * @return SetlistSearchBuilder
      */
     public function withVenueName(string $name): self
@@ -216,8 +186,6 @@ public function withVenueName(string $name): self
     }
 
     /**
-     * @param string $venueId
-     *
      * @return SetlistSearchBuilder
      */
     public function withVenueId(string $venueId): self
@@ -227,9 +195,6 @@ public function withVenueId(string $venueId): self
         return $this;
     }
 
-    /**
-     * @return array
-     */
     public function getQuery(): array
     {
         return $this->query;

diff --git a/src/Builder/VenueSearchBuilder.php b/src/Builder/VenueSearchBuilder.php
@@ -32,8 +32,6 @@ public static function create(): self
     }
 
     /**
-     * @param int $page
-     *
      * @return VenueSearchBuilder
      */
     public function page(int $page): self
@@ -44,8 +42,6 @@ public function page(int $page): self
     }
 
     /**
-     * @param string $name
-     *
      * @return VenueSearchBuilder
      */
     public function withName(string $name): self
@@ -56,8 +52,6 @@ public function withName(string $name): self
     }
 
     /**
-     * @param string $name
-     *
      * @return VenueSearchBuilder
      */
     public function withCity(string $name): self
@@ -68,8 +62,6 @@ public function withCity(string $name): self
     }
 
     /**
-     * @param int $id
-     *
      * @return VenueSearchBuilder
      */
     public function withCityId(int $id): self
@@ -80,8 +72,6 @@ public function withCityId(int $id): self
     }
 
     /**
-     * @param string $country
-     *
      * @return VenueSearchBuilder
      */
     public function withCountry(string $country): self
@@ -92,8 +82,6 @@ public function withCountry(string $country): self
     }
 
     /**
-     * @param string $name
-     *
      * @return VenueSearchBuilder
      */
     public function withState(string $name): self
@@ -104,8 +92,6 @@ public function withState(string $name): self
     }
 
     /**
-     * @param string $code
-     *
      * @return VenueSearchBuilder
      */
     public function withStateCode(string $code): self
@@ -115,9 +101,6 @@ public function withStateCode(string $code): self
         return $this;
     }
 
-    /**
-     * @return array
-     */
     public function getQuery(): array
     {
         return $this->query;

diff --git a/src/Connection/AbstractConnection.php b/src/Connection/AbstractConnection.php
@@ -29,7 +29,6 @@ abstract class AbstractConnection implements ConnectionInterface
     private $uri;
 
     /**
-     * @param string $apikey
      * @param string $uri
      */
     public function __construct(string $apikey, string $uri = null)
@@ -42,17 +41,11 @@ public function __construct(string $apikey, string $uri = null)
         $this->uri    = $uri;
     }
 
-    /**
-     * @return string
-     */
     final protected function getApiKey(): string
     {
         return $this->apiKey;
     }
 
-    /**
-     * @return string
-     */
     final protected function getUri(): string
     {
         return $this->uri;

diff --git a/src/Connection/ConnectionInterface.php b/src/Connection/ConnectionInterface.php
@@ -19,14 +19,8 @@ interface ConnectionInterface
     /**
      * Calls the API.
      *
-     * @param string $method
-     * @param array  $params
-     * @param string $requestMethod
-     *
      * @throws ApiException
      * @throws NotFoundException
-     *
-     * @return array
      */
     public function call(string $method, array $params = [], string $requestMethod = 'GET'): array;
 }