Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverse plugin still has README, even though it was removed #2702

Closed
Feder1co5oave opened this issue Mar 15, 2019 · 1 comment
Closed

Reverse plugin still has README, even though it was removed #2702

Feder1co5oave opened this issue Mar 15, 2019 · 1 comment

Comments

@Feder1co5oave
Copy link

Feder1co5oave commented Mar 15, 2019 •
edited
Loading

https://coredns.io/plugins/reverse/ still contains documentation of the reverse plugin, even though it was deprecated after #1502 and then removed in #1713. No mention of this is present on that page, nor on the plugin list: https://coredns.io/plugins/.

Putting it in the Corefile causes coredns to issue a "reverse directive unknown", as it should.

I guess this violates the non-mandatory rules for plugin deprecation proposed in #1384 (comment)
@miekg
Copy link
Member

miekg commented Mar 15, 2019

that should have been removed, please open a pr/issue against the coredns.io repo

@miekg miekg closed this as completed Mar 15, 2019
@Feder1co5oave Feder1co5oave mentioned this issue Mar 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@miekg @Feder1co5oave