Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standard compliant errors on EDNS0 #77

Closed
miekg opened this issue Apr 4, 2016 · 4 comments
Closed

standard compliant errors on EDNS0 #77

miekg opened this issue Apr 4, 2016 · 4 comments

Comments

@miekg
Copy link
Member

miekg commented Apr 4, 2016

Support NSID (middleware thingy?)

And correctly return an EDNS0 error when we don't understand the OPT RR. Google for some ravings of marka on this subject.

@miekg miekg mentioned this issue Apr 8, 2016
@miekg
Copy link
Member Author

miekg commented Apr 8, 2016

@miekg
Copy link
Member Author

miekg commented Apr 8, 2016

First test:

% dig +norec +edns=0 soa miek.nl @linode.atoom.net                            ~
;; ->>HEADER<<- opcode: QUERY; status: NOERROR; id: 59413
;; Flags: qr aa ra; QUERY: 1; ANSWER: 1; AUTHORITY: 0; ADDITIONAL: 0

;; QUESTION SECTION:
;; miek.nl.                 IN  SOA

;; ANSWER SECTION:
miek.nl.                1800    IN  SOA linode.atoom.net. miek.miek.nl. 1460088781 14400 3600 604800 14400

;; Received 82 B
;; Time 2016-04-08 07:40:23 BST
;; From 2a01:7e00::f03c:91ff:feae:e74c@53(UDP) in 9.7 ms

Missing

;; EDNS PSEUDOSECTION:
;; Version: 0; flags: ; UDP size: 4096 B; ext-rcode: Unused

For instance...

Should just put the above page in an edns0_test.go file, load a fake zone. Also take care that that "dropped" zone (i.e. did not enter the middleware) takes care of this. Also check the etcd middleware, prolly need a function in the middleware directory that does most of this, or on state and cache a few bits...

@miekg
Copy link
Member Author

miekg commented Apr 8, 2016

I could add a middleware to add or fixes the EDNS0 in the packet, this would work similar to the rewrite middleware, but is on by default. The only downside is TSIG signed packets - also [IA]XFR... might just go ahead and fix this for the file middleware, see what can be applied to etcd middleware, abstract that and put in the middleware directory.

@miekg miekg changed the title NSID and standard compliant errors on EDNS0 standard compliant errors on EDNS0 Apr 9, 2016
@miekg
Copy link
Member Author

miekg commented Apr 9, 2016

Fixed in all middleware, respond correctly to EDNS0 options in the middleware.

@miekg miekg closed this as completed Apr 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant