Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please support configuring environment variables for the cluster-proportional-autoscaler container #151

Open
stevo-f3 opened this issue Nov 16, 2023 · 1 comment

Comments

@stevo-f3
Copy link

stevo-f3 commented Nov 16, 2023

E.g. to enable configuring Go runtime with GOMAXPROCS and GOMEMLIMITS environment variables.

Optionally, consider setting GOMAXPROCS and GOMEMLIMITS env vars automatically relative to the configured resources (CPU requests, and memory limits, respectively), when resources are configured.

With current default resource configuration (20m CPU requests and limits) and no GOMAXPROCS configured, there's lots of CPU throttling. Upstream chart doesn't set default resource configuration, so partially issue could be solved with #103 - at least it would move upstream.

@hagaibarel
Copy link
Collaborator

I understand your point, but at this point I wouldn't want to make any changes until we get #103 done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants