Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in node identifier of uses augment? #55

Closed
vcshox opened this issue Jan 20, 2017 · 3 comments
Closed

bug in node identifier of uses augment? #55

vcshox opened this issue Jan 20, 2017 · 3 comments

Comments

@vcshox
Copy link
Contributor

vcshox commented Jan 20, 2017

yang-module:

module uses-aug {

  grouping foo-grp {
    container cont-to-be-aug {

    }
  }
  uses foo-grp {
    augment "./cont-to-be-aug" {
      leaf leaf-a {
        type string;
      }
    }
  }
}

After the module is loaded, I loop over every element in the yang instance, no additional node is augmented.

After checking the RFC, ./cont-to-be-aug does not seem to be a formal node identifier.
Maybe an error message is needed?

Even I set the value as a "./123"(a non-existing node), the situation is the same.

@sekur
Copy link
Collaborator

sekur commented Jan 20, 2017

Yes, ./xxx is not a valid path identifier. We can add a simple validation logic to augment extension's resolve function to make sure it's compliant. Do you want to give it a try?

@vcshox
Copy link
Contributor Author

vcshox commented Jan 20, 2017

ok, I will

@vcshox vcshox closed this as completed Jan 23, 2017
@sekur
Copy link
Collaborator

sekur commented Jan 23, 2017

@vcshox - thanks for your PR #56!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants