Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize fcos 1.5.0 #434

Closed
prestist opened this issue Mar 6, 2023 · 13 comments · Fixed by #442
Closed

Stabilize fcos 1.5.0 #434

prestist opened this issue Mar 6, 2023 · 13 comments · Fixed by #442
Assignees
Labels

Comments

@prestist
Copy link
Contributor

prestist commented Mar 6, 2023

Pending #289

Following the steps found in https://coreos.github.io/butane/development/ re stabilization.

@prestist prestist self-assigned this Mar 6, 2023
@prestist prestist added the jira label Mar 6, 2023
@bgilbert
Copy link
Contributor

bgilbert commented Mar 9, 2023

@tormath1 @7flying It'd make sense for us to stabilize flatcar 1.1.0 and r4e 1.1.0 also, so users of those distros can use the new features in the Ignition 3.4.0 spec. Does that work for you? Otherwise we'll bump flatcar 1.1.0-experimental and/or r4e 1.1.0-experimental to the Ignition 3.5.0-experimental spec.

@tormath1
Copy link
Contributor

Hello @bgilbert, that makes sense yes, on the Flatcar side, we updated Ignition to 2.15.0 on the latest Alpha. If I understand correctly, we would have:
butane 1.0.0 -> ignition 3.3.0
butane 1.1.0 -> ignition 3.4.0
and a new butane 1.2.0-experimental -> ignition 3.5.0-experimental ?

@travier
Copy link
Member

travier commented Mar 10, 2023

yes, that's the idea

@travier
Copy link
Member

travier commented Mar 10, 2023

https://coreos.github.io/butane/specs/#butane-specifications-and-ignition-specifications

@tormath1
Copy link
Contributor

Ok perfect - let me know if you want us to send a PR for Flatcar :)

@travier
Copy link
Member

travier commented Mar 10, 2023

I think we'll do it together in a single PR for all specs

@travier
Copy link
Member

travier commented Mar 10, 2023

CC @runcom for R4E

@7flying
Copy link
Contributor

7flying commented Mar 10, 2023

So in edge we have all the docs already asking the users to use the rfe variant at version 1.0.0 which targets Ignition 3.3.0.
We can stabilise 1.1.0 since the subset of options that we support is the same one as 1.0.0 has, unless there are some other implications that I'm not aware of.

@travier
Copy link
Member

travier commented Mar 10, 2023

RHEL 9.2 will have Ignition 2.15 that will be able to use the 3.4.0 Ignition spec. Not sure how much of an improvement that is for R4E.

@7flying
Copy link
Contributor

7flying commented Mar 10, 2023

RHEL 9.2 will have Ignition 2.15 that will be able to use the 3.4.0 Ignition spec. Not sure how much of an improvement that is for R4E.

Is that Ignition 2.15 still able to handle Ignition spec 3.3.0 if we say r4e v1.0.0? If not I will have to notify the docs team

@bgilbert
Copy link
Contributor

Yes. Stabilizing a new spec does not affect existing specs.

@bgilbert
Copy link
Contributor

Thanks for the feedback @tormath1 and @7flying! We'll plan to stabilize both the flatcar and r4e specs.

@bgilbert
Copy link
Contributor

This can happen after #441 lands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants