New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: make a single-binary only project #113
Conversation
This ensures that the coreos-metadata crate only provides a single binary. The corresponding library is not supposed to be externally consumed and is not guaranteed to have a stable API (at the moment).
This updates all dependencies within their compatible semver ranges.
This adds all required fields for publishing on crates.io.
yeah, the primary purpose is definitely just to provide the binary. There isn't really a good reason to pin ourselves in by exposing the library part at this point, at least as far as I can see. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose technically this requires a 3.0
🙂
@csssuf why? We never published the crate and we are dropping the library, so the semver does not apply to that. For the binary, IMHO the versioning is pretty much arbitrary. I think we will need to bump to |
I'm merging this for now. I am happy to continue the versioning discussion here and account for that when preparing the next release PR. |
@lucab We bumped to 2.0.0 when we changed the API of the library portion for the |
@csssuf my reasoning is that:
If the first is not true, then your concern is valid. In that case, I think it may be safer to just bump to 3.0.0 and be done with the library. People (if any) could still lock into library 2.0.0 via git dependency. |
This prepares for the next major version. For rationale, see coreos#113 (comment)
This prepares for the next major version. For rationale, see coreos#113 (comment)
This prepares for the next major version. For rationale, see coreos#113
As the outcome of this discussion, to be on the safe side I'm bumping the current development series version in #114. |
This ensures that the coreos-metadata crate only provides a single
binary. The corresponding library is not supposed to be externally
consumed and is not guaranteed to have a stable API (at the moment).
It also updates dependencies and adjusts cargo manifest for publishing
the next version.