etcdmain: start on unsupported arch when ETCD_UNSUPPORTED_ARCH is set #5028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -141,8 +141,9 @@ The `v2` API responses should not change after the 2.0.0 release but new feature | |||
|
|
|||
| etcd has known issues on 32-bit systems due to a bug in the Go runtime. See #[358][358] for more information. | |||
|
|
|||
| To avoid inadvertantly producing an unstable etcd server, 32-bit builds emit an `etcd` that prints | |||
| a warning message and immediately exits. | |||
| To avoid inadvertantly running a possibly unstable etcd server, `etcd` on unsupported architectures will print | |||
There was a problem hiding this comment.
shall we mention that the only supported arch is amd64 right now?
heyitsanthony
force-pushed
the
etcdmain-unsupported-envvar
branch
2 times, most recently
from
4962d4d
to
c4caa65
Compare
|
all fixed /cc @xiang90 |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.