Documentation/proxy: Change proxy port from 8080 to 2379 #5756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref etcd-io#5693 in v3 track (master). Ref backport to 2.3.7 docs in https://github.com/coreos-inc/coreos-pages/pull/747
|
lgtm. thanks. /cc @xiang90 |
|
@gyuho Do you know why the build fails on 2.3.x branch? |
|
@xiang90 It's failing from goword https://travis-ci.org/coreos/etcd/jobs/139683761#L361. But I think we can ignore for this PR? |
|
goword added package checking on march 19th, 2.3.0 shipped on march 18th, so the breakage makes sense since it's pulling from master. Maybe the static tests should lock a commit revision on the tooling so backporting doesn't explode? lgtm |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #5693 in v3 track (master).
Ref backport to 2.3.7 docs in https://github.com/coreos-inc/coreos-pages/pull/747