Backport arm fixes #6622
Merged
Backport arm fixes #6622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The relevant structures are properly aligned, however, there is no comment highlighting the need to keep it aligned as is present elsewhere in the codebase. Adding note to keep alignment, in line with similar comments in the codebase.
The Entry struct has misaligned fields that are accessed atomically. The misalignment is caused by the EntryType enum which the Protocol Buffers spec forces to be a 32bit int. Moving the order of the fields without renumbering them in the .proto file seems to align the go structure without changing the wire format.
Most fields accessed with sync/atomic functions are 64bit aligned, but a couple are not. This makes comments out of date and therefore misleading. Affected fields reordered, comments scrubbed and updated.
|
lgtm; ci errors are unrelated |
|
lgtm. It's minor change with low-risk. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #5890 to the release-3.0 branch for inclusion in 3.0.13
ref: kubernetes/kubernetes#32361
This is required for arm to function properly on the 3.0.x branch which Kubernetes probably will use in v1.5
It's very very low risk, so it should be straightforward to merge this
@gyuho @xiang90 @hongchaodeng @lavalamp @wojtek-t @jaredeh