Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: replace path.Join on files with filepath.Join #7518

Merged
merged 1 commit into from Mar 16, 2017

Conversation

heyitsanthony
Copy link
Contributor

Full audit of codebase. Continuation of #7515

@heyitsanthony
Copy link
Contributor Author

can squash into single commit if it makes sense; a lot of commits in this one...

@codecov-io
Copy link

codecov-io commented Mar 16, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@d78b03f). Click here to learn what that means.
The diff coverage is 93.54%.

@@           Coverage Diff            @@
##             master   #7518   +/-   ##
========================================
  Coverage          ?   70.2%           
========================================
  Files             ?     320           
  Lines             ?   26203           
  Branches          ?       0           
========================================
  Hits              ?   18397           
  Misses            ?    6347           
  Partials          ?    1459
Impacted Files Coverage Δ
etcdctl/ctlv3/command/snapshot_command.go 64.77% <100%> (ø)
etcdctl/ctlv3/command/migrate_command.go 63.78% <100%> (ø)
embed/etcd.go 67.22% <100%> (ø)
etcdserver/config.go 77.21% <100%> (ø)
etcdserver/server.go 79.37% <100%> (ø)
pkg/transport/listener.go 85.5% <100%> (ø)
etcdctl/ctlv2/command/backup_command.go 55.55% <100%> (ø)
etcdmain/etcd.go 45.33% <100%> (ø)
snap/db.go 64.51% <100%> (ø)
mvcc/backend/backend.go 73.75% <100%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d78b03f...2f1542c. Read the comment docs.

@xiang90
Copy link
Contributor

xiang90 commented Mar 16, 2017

LGTM. I am wondering how etcd managed to work on windows before...

@gyuho
Copy link
Contributor

gyuho commented Mar 16, 2017

don't think we would backport these. we can just merge them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants