Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: move "auth" to "internal/auth" #9243

Merged
merged 3 commits into from
Jan 29, 2018
Merged

Conversation

mitake
Copy link
Contributor

@mitake mitake commented Jan 29, 2018

/cc @gyuho

For #9220.

Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks!

Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@ce0ad37). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #9243   +/-   ##
=========================================
  Coverage          ?   75.86%           
=========================================
  Files             ?      363           
  Lines             ?    30194           
  Branches          ?        0           
=========================================
  Hits              ?    22907           
  Misses            ?     5681           
  Partials          ?     1606
Impacted Files Coverage Δ
internal/auth/range_perm_cache.go 66.17% <ø> (ø)
internal/auth/simple_token.go 87.03% <ø> (ø)
etcdserver/api/v3rpc/util.go 78.26% <ø> (ø)
etcdserver/apply.go 91.16% <ø> (ø)
etcdserver/apply_auth.go 78.62% <ø> (ø)
etcdserver/v3_server.go 81.65% <ø> (ø)
internal/auth/store.go 82.11% <ø> (ø)
clientv3/auth.go 95.94% <ø> (ø)
internal/auth/jwt.go 82.43% <ø> (ø)
etcdserver/api/v3rpc/watch.go 83.26% <ø> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce0ad37...9c6c830. Read the comment docs.

@mitake mitake merged commit 0e2f9ea into etcd-io:master Jan 29, 2018
@mitake mitake deleted the auth-internal branch January 29, 2018 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants