Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: revert "internal" package changes #9274

Merged
merged 15 commits into from
Feb 27, 2018
Merged

*: revert "internal" package changes #9274

merged 15 commits into from
Feb 27, 2018

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Feb 2, 2018

External tools like "etcd-dump-db" outside of etcd repository need
access to "mvccpb" and other packages. Should not be under internal.

Also projects that use clientv3 use mvccpb.PUT, and so on.

See https://github.com/search?l=Go&q=mvccpb.&type=Code&utf8=%E2%9C%93.

@gyuho gyuho requested review from mitake and xiang90 February 2, 2018 23:01
@gyuho gyuho added the WIP label Feb 3, 2018
@gyuho gyuho requested a review from jpbetz February 3, 2018 00:02
@gyuho
Copy link
Contributor Author

gyuho commented Feb 3, 2018

Marked it as WIP.

We need to research more if there's any better way to handle it, before 3.4 release.

@gyuho gyuho added this to the v3.4.0 milestone Feb 3, 2018
@gyuho gyuho changed the title *: revert "internal/mvcc,auth,lease" *: revert "internal" package changes Feb 26, 2018
@gyuho
Copy link
Contributor Author

gyuho commented Feb 26, 2018

I will revert internal packages for now, since it's breaking a lot of external projects relying on authpb, mvccpb, etc. We can discuss again how to organize internal packages later.

Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
@gyuho gyuho merged commit 5b9741e into etcd-io:master Feb 27, 2018
@gyuho gyuho deleted the revert branch February 27, 2018 01:13
@codecov-io
Copy link

Codecov Report

Merging #9274 into master will increase coverage by 0.01%.
The diff coverage is 50.99%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9274      +/-   ##
==========================================
+ Coverage   72.74%   72.76%   +0.01%     
==========================================
  Files         361      361              
  Lines       30717    30717              
==========================================
+ Hits        22346    22352       +6     
+ Misses       6766     6758       -8     
- Partials     1605     1607       +2
Impacted Files Coverage Δ
etcdserver/v2store/watcher.go 86.36% <ø> (ø)
etcdserver/v2store/event.go 100% <ø> (ø)
mvcc/backend/config_linux.go 100% <ø> (ø)
etcdctl/ctlv2/command/backup_command.go 67.56% <ø> (ø) ⬆️
etcdserver/v2store/metrics.go 92% <ø> (ø)
mvcc/kv.go 40% <ø> (ø)
etcdserver/backend.go 70.58% <ø> (ø) ⬆️
etcdserver/corrupt.go 54.42% <ø> (ø) ⬆️
etcdserver/v2error/error.go 91.66% <ø> (ø)
compactor/compactor.go 0% <ø> (ø)
... and 111 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6b46ac...2dd8af3. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants