Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcdserver: move "etcdserver/auth" to "etcdserver/v2auth" #9275

Merged
merged 1 commit into from
Feb 5, 2018
Merged

etcdserver: move "etcdserver/auth" to "etcdserver/v2auth" #9275

merged 1 commit into from
Feb 5, 2018

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Feb 2, 2018

Confusing with v3 auth package, and this is internal to etcdserver, anyway.

@gyuho
etcdserver: move "etcdserver/auth" to "etcdserver/v2auth"
eecbba7 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
@gyuho gyuho requested review from mitake and xiang90 February 2, 2018 23:07
mitake
mitake approved these changes Feb 5, 2018
View reviewed changes
Copy link
Contributor

@mitake mitake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. The CI failure doesn't seem to be related to this change.

@gyuho gyuho merged commit 07f9229 into etcd-io:master Feb 5, 2018
@gyuho gyuho deleted the v2auth branch February 5, 2018 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitake mitake mitake approved these changes

@xiang90 xiang90 Awaiting requested review from xiang90

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gyuho @mitake