Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Ignition support in an Ignition RPM sub-package (like ignition-edge) #1582

Open
travier opened this issue Sep 25, 2023 · 5 comments
Open
Assignees

Comments

@travier
Copy link
Member

travier commented Sep 25, 2023

Describe the enhancement

Ignition support in Fedora CoreOS is now mature and less likely to drastically change. Let's split all the units, config, services, etc. in an ignition RPM sub-package.

This would let us more easily include Ignition support in Project Sagano images: https://gitlab.com/CentOS/cloud/sagano

This will also enable us to de-duplicate the effort with https://github.com/fedora-iot/ignition-edge.

To reduce the impact on development speed, we would enable CI in the new repo and add auto-packaging updates with packit for the Fedora package.

System details

N/A

Additional information

Another alternative is to teach rpm-ostree to handle overlays during compose and use that instead of having the logic in COSA.

@travier travier added kind/enhancement meeting topics for meetings jira for syncing to jira status/decided status/pending-action Needs action and removed meeting topics for meetings labels Sep 25, 2023
@travier
Copy link
Member Author

travier commented Sep 27, 2023

From today's meeting:

  * AGREED: We'll split Ignition support config and services from
    fedora-coreos-config into another repo and include them in FCOS via
    an Ignition subpackage, similarly to how ignition-edge does it
    today, eventually replacing it  (travier, 17:22:01)

I'll make a PoC before moving forward.

@travier travier self-assigned this Oct 10, 2023
@runcom
Copy link
Member

runcom commented Nov 21, 2023


I'll make a PoC before moving forward.

cc @7flying too - I think we could work together on making sure the new package passes CI and it's integrated into edge too

@7flying
Copy link

7flying commented Nov 22, 2023

@travier I have some free cycles, so feel free to ping me if you need any assistance, testing etc

@travier
Copy link
Member Author

travier commented Jan 15, 2024

Current plans:

  • Split this into a proper package instead of using a subpackage
  • Integrate with Packit to auto-release updates in Fedora
  • Integrate with CoreOS CI

@travier
Copy link
Member Author

travier commented Jan 23, 2024

Great explanation from Benjamin in #1311 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants