Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

Change logic of grpc client without calling ClientConn.State() #1672

Closed
dongsupark opened this issue Aug 25, 2016 · 0 comments
Closed

Change logic of grpc client without calling ClientConn.State() #1672

dongsupark opened this issue Aug 25, 2016 · 0 comments

Comments

@dongsupark
Copy link
Contributor

dongsupark commented Aug 25, 2016

As noted in #1671, we cannot update google.golang.org/grpc to v1.0 or master, because ClientConn.State() is now gone. That's why we must stay with 178b68e2 ("Merge pull request 556 from bradfitz/testcleanup", 2016-02-17) to avoid build errors.

So solution would be to change registry/rpc/rpcregistry.go in fleet to avoid using ClientConn.State(). Though AFAICT it's not trivial to change the logic.

See also etcd-io/etcd#5583

/cc @hectorj2f

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant