Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename login1.Conn to login1.Client or similar #389

Open
invidian opened this issue Jan 10, 2022 · 0 comments
Open

Rename login1.Conn to login1.Client or similar #389

invidian opened this issue Jan 10, 2022 · 0 comments

Comments

@invidian
Copy link

I think login1.Conn name is not very accurate, as it leaks the abstraction on how login1 methods are called underneath (via some kind of connection).

Also, right now login1 package is responsible for connecting and authenticating to D-Bus, which seems like both possible waste of resources, as multiple clients can't share the connection and it also affects testability of code, as no mock D-Bus connection can be given to a login1 client. It seems like responsibility to proxy connections to D-Bus should be out of scope for this package/struct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant