Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to delete inodes #739

Open
bgilbert opened this issue Feb 22, 2019 · 4 comments
Open

Add a way to delete inodes #739

bgilbert opened this issue Feb 22, 2019 · 4 comments
Labels
area/usability jira for syncing to jira kind/enhancement spec change Requires changes to the spec

Comments

@bgilbert
Copy link
Contributor

Feature Request

Environment

Any

Desired Feature

Add a way to remove existing files/directories/links.

Other Information

I don't have a use case in mind, and it's not clear that removal of a file shipped with the OS is a common operation. But it might be good to include this for completeness. The main use might be for overriding a parent config.

It doesn't really make sense to add a shouldExist property to each of files/directories/links, since deleting an inode shouldn't require knowing its type. But adding a list of whiteouts/things-to-delete also seems awkward.

I don't think this functionality is critical for 3.0.

@ajeddeloh ajeddeloh added the spec change Requires changes to the spec label Oct 11, 2019
@sohankunkerkar sohankunkerkar self-assigned this Jun 16, 2020
@sohankunkerkar sohankunkerkar added the jira for syncing to jira label Jun 18, 2020
@sohankunkerkar
Copy link
Member

sohankunkerkar commented Jul 16, 2020

Any suggestions here to address this issue?
@bgilbert @arithx @jlebon @lucab

@sohankunkerkar
Copy link
Member

sohankunkerkar commented Jul 16, 2020

One approach here (after discussing with @bgilbert ) would be to create a separate array of nodes to remove inodes. What other folks think about it?

@jdmarble
Copy link

Just offering up a use case for this feature. I'm attempting to disable systemd-resolved.service as described here. If I don't delete the symbolic link /etc/resolv.conf, then NetworkManager will not generate a functional version of it and DNS queries fail.

@bgilbert
Copy link
Contributor Author

@jdmarble For that specific case, it's sufficient to replace the symlink with an empty file:

variant: fcos
version: 1.0.0
storage:
  files:
    - path: /etc/resolv.conf
systemd:
  units:
    - name: systemd-resolved.service
      mask: true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/usability jira for syncing to jira kind/enhancement spec change Requires changes to the spec
Projects
None yet
Development

No branches or pull requests

4 participants