*: add kernel argument support #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgilbert
reviewed
Mar 25, 2021
|
Okay, updated for comments. Additionally I went ahead and updated |
arithx
commented
Mar 26, 2021
bgilbert
reviewed
Mar 26, 2021
arithx
force-pushed
the
ign_kargs
branch
3 times, most recently
from
aa8839d
to
3aae119
Compare
|
⏫ Updated ⏫ |
bgilbert
reviewed
Apr 28, 2021
|
Updated, will still potentially need another update pending questions in #1178 (comment) & #1178 (comment) |
bgilbert
reviewed
Apr 29, 2021
bgilbert
reviewed
Apr 29, 2021
added 3 commits
April 28, 2021 22:22
Adds a new top-level struct kernelArguments which has two fields, shouldExist & shouldNotExist both of which accept lists of strings.
Adds a new stage kargs which will call out to an external binary to set kernel arguments during the first boot. This is done in a separate stage to allow the distribution to set kernel arguments before the disks stage is run and optionally reboot.
|
Updated |
bgilbert
reviewed
Apr 29, 2021
arithx
force-pushed
the
ign_kargs
branch
2 times, most recently
from
ce69013
to
c4142c8
Compare
added 2 commits
April 29, 2021 00:07
Adds a new kargs stage, as well as a binary implementation that prompts the user to contact their distribution to implement a kargs helper binary.
bgilbert
approved these changes
Apr 29, 2021
sohankunkerkar
added a commit
to sohankunkerkar/butane
that referenced
this pull request
Apr 29, 2021
Related to coreos/ignition#1178 This change adds support for providing a kernelArgument field in the butane config.
sohankunkerkar
added a commit
to sohankunkerkar/butane
that referenced
this pull request
Apr 29, 2021
Related to coreos/ignition#1178 This change adds support for providing a kernelArgument field in the butane config.
sohankunkerkar
added a commit
to sohankunkerkar/butane
that referenced
this pull request
Apr 30, 2021
Related to coreos/ignition#1178 This change adds support for providing a kernelArgument field in the butane config.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new top-level field
kernelArgumentto the configuration specification, a new Ignition stagekargs, and distributor documentation.Closes #1168