Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate records in prometheus-rules #134

Closed
chiefy opened this issue Jun 27, 2019 · 6 comments
Closed

Duplicate records in prometheus-rules #134

chiefy opened this issue Jun 27, 2019 · 6 comments

Comments

@chiefy
Copy link

chiefy commented Jun 27, 2019

There's duplicate records for namespace:container_cpu_usage_seconds_total:sum_rate and namespace:container_memory_usage_bytes:sum here: https://github.com/coreos/kube-prometheus/blob/master/manifests/prometheus-rules.yaml#L15-L30

@brancz
Copy link
Collaborator

brancz commented Jul 2, 2019

Thanks for reporting! This is actually pulled in through the kubernetes-mixin dependency, we're gonna need to fix it there. Can you open an issue there? :)

RE: https://github.com/kubernetes-monitoring/kubernetes-mixin/blob/master/rules/rules.libsonnet

@brancz
Copy link
Collaborator

brancz commented Jul 2, 2019

cc @metalmatze

@metalmatze
Copy link
Member

Interesting. We should discuss upstream, if we need both (as the might be different) or can get rid of one after the Kubernetes metrics overhaul.
Let's discuss there.

@simonpasquier
Copy link
Contributor

I've filed kubernetes-monitoring/kubernetes-mixin#230 to follow up.

@BenoitKnecht
Copy link
Contributor

This was fixed in kubernetes-monitoring/kubernetes-mixin#230, and kube-prometheus now depends on kubernetes-monitoring/kubernetes-mixin@15ddfa2, which includes the fix (kubernetes-monitoring/kubernetes-mixin@32c7960).

@brancz
Copy link
Collaborator

brancz commented Oct 24, 2019

Thanks @BenoitKnecht !

@brancz brancz closed this as completed Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants