Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use kubectl apply instead of create #2327

Merged
merged 2 commits into from Jan 23, 2019
Merged

Use kubectl apply instead of create #2327

merged 2 commits into from Jan 23, 2019

Conversation

scruplelesswizard
Copy link
Contributor

Resources can be created and updated with apply without receiving errors

Resources can be created _and_ updated with `apply` without receiving errors
@brancz
Copy link
Contributor

brancz commented Jan 23, 2019

If I recall correct replaced it with apply because some of our objects were too large to fit into the "last applied" annotation. Could you try applying multiple times and see if this is still the case? If not I'm happy to change this back (I believe it used to be the Grafana dashboards that used to be in one giant ConfigMap).

@scruplelesswizard
Copy link
Contributor Author

I don't experience the mentioned behaviour on v1.13.2 , but it may still be the case for older clusters.

@brancz
Copy link
Contributor

brancz commented Jan 23, 2019

That's validation enough for me :)

In that case can you remove the || true and 2>/dev/null || true, as those were only added to safely run create multiple times without a non 0 exit code.

@brancz
Copy link
Contributor

brancz commented Jan 23, 2019

Thanks!

@brancz brancz merged commit 1169629 into prometheus-operator:master Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants