This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
configure: print full go version and check against CVE-2015-8618 #2006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It fails on Travis: I need to update |
alban
force-pushed
the
alban/go-version-1
branch
from
8841f14
to
d0daaba
Compare
| [AC_MSG_RESULT([yes]) | ||
| RKT_XF() { | ||
| echo "-X $1 '$2'" | ||
| }], | ||
| [AC_MSG_ERROR([*** go is too old (${GO_VERSION})])])]) | ||
|
|
||
| AC_MSG_CHECKING([whether we have a go version without CVE-2015-8618]) | ||
| AS_IF([test "${GO_MAJOR}" -eq "1" -a "${GO_MINOR}" -eq "5" -a "${GO_MICRO}" -lt "3"], |
There was a problem hiding this comment.
AS_IF([test "${GO_MAJOR}" -eq "1" -a "${GO_MINOR}" -eq "5" -a "${GO_MICRO}" -lt "3"],
[AC_MSG_RESULT([no])
AC_MSG_ERROR([*** go version is vulnerable to CVE-2015-8618 (${GO_VERSION})])],
[AC_MSG_RESULT([yes])])
|
LFAD, small formatting nit and a one bracket too much. :) |
alban
force-pushed
the
alban/go-version-1
branch
from
d0daaba
to
509695b
Compare
./configure already prints the go version, but unfortunately only the major.minor numbers without the micro: > go version: '1.5' This patch prints the full version instead: > go version: '1.5.3' Additionally, it checks that the go version is not 1.5.0, 1.5.1 or 1.5.2 to be absolutely sure it is not vulnerable to CVE-2015-8618.
|
Thanks! Updated. |
alban
added a commit
that referenced
this pull request
Jan 20, 2016
configure: print full go version and check against CVE-2015-8618
alban
added a commit
to kinvolk/rkt
that referenced
this pull request
Feb 3, 2016
Ubuntu does not have golang 1.5.3 yet, so the check was completely blocking the build on Ubuntu. Replace it with a warning. Related to rkt#2006
alban
added a commit
to kinvolk/rkt
that referenced
this pull request
Feb 3, 2016
Ubuntu does not have golang 1.5.3 yet, so the check was completely blocking the build on Ubuntu. Replace it with a warning. Related to rkt#2006
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./configure already prints the go version, but unfortunately only the
major.minor numbers without the micro:
This patch prints the full version instead:
Additionally, it checks that the go version is not 1.5.0, 1.5.1 or 1.5.2
to be absolutely sure it is not vulnerable to CVE-2015-8618.