This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
image: Validate docker url in dockerfetcher. #2134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -51,6 +51,9 @@ type dockerFetcher struct { | |||
| func (f *dockerFetcher) GetHash(u *url.URL) (string, error) { | |||
| ensureLogger(f.Debug) | |||
| dockerURL := d2acommon.ParseDockerURL(path.Join(u.Host, u.Path)) | |||
| if dockerURL == nil { | |||
| return "", fmt.Errorf("Invalid docker URL") | |||
There was a problem hiding this comment.
We don't capitalize error strings.
Also, maybe we can help the user a bit more by showing the valid syntax:
fmt.Errorf("invalid docker URL %q. Syntax docker://[REGISTRYURL/]IMAGE_NAME[:TAG]", u)
Passing an invalid docker url such as docker:run crashes rkt otherwise
with
```
sudo ./build-rkt-1.0.0+git/bin/rkt run docker:busybox
image: using image from file /usr/lib/rkt/stage1.aci
image: remote fetching from URL "docker:busybox"
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xb code=0x1 addr=0x0 pc=0x5e4314]
goroutine 1 [running, locked to thread]:
github.com/coreos/rkt/rkt/image.(*dockerFetcher).GetHash(0xc82033b2f0, 0xc820322080, 0x0, 0x0, 0x0, 0x0)
/home/raghu/repo/go/src/github.com/coreos/rkt/build-rkt-1.0.0+git/gopath/src/github.com/coreos/rkt/rkt/image/dockerfetcher.go:54 +0x1f4
github.com/coreos/rkt/rkt/image.(*Fetcher).maybeFetchDockerURLFromRemote(0xc82033ba50, 0xc820322080, 0x0, 0x0, 0x0, 0x0)
/home/raghu/repo/go/src/github.com/coreos/rkt/build-rkt-1.0.0+git/gopath/src/github.com/coreos/rkt/rkt/image/fetcher.go:249 +0x1ab
github.com/coreos/rkt/rkt/image.(*Fetcher).fetchSingleImageByDockerURL(0xc82033ba50, 0xc820322080, 0x0, 0x0, 0x0, 0x0)
/home/raghu/repo/go/src/github.com/coreos/rkt/build-rkt-1.0.0+git/gopath/src/github.com/coreos/rkt/rkt/image/fetcher.go:187 +0x12b
```
Full trace:
https://gist.github.com/ronin13/bb82648c5d48ee68e808
This happens because ParseDockerURL output is not checked for nil.
With the fix it shows like:
```
sudo ./build-rkt-1.0.0+git/bin/rkt run --interactive docker:busybox
image: using image from local store for image name coreos.com/rkt/stage1-coreos:1.0.0+git6146a78
image: remote fetching from URL "docker:busybox"
run: Invalid docker URL
```
|
Maybe docker2aci should be changed to return an error here? Returning |
|
+1 to @krnowak |
|
Alright: appc/docker2aci#119 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing an invalid docker url such as docker:run crashes rkt otherwise
with
Full trace:
https://gist.github.com/ronin13/bb82648c5d48ee68e808
This happens because ParseDockerURL output is not checked for nil.
With the fix it shows like: