This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
rkt: fix panic on rm a non-existing pod with uuid-file #2679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm - test? |
|
Added tests. |
We were trusting that the value in the uuid file referred to an existing pod, which caused a panic if that wasn't the case. In this commit we resolve the UUID to check if the pod actually exists. Also, make rm's behavior consistent between caling it with a pod UUID and with `--uuid-file`: * Print a similar error message * Set the exit status to 1 if we fail to remove any pod
|
Rebased. PTAL. |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were trusting that the value in the uuid file referred to an existing
pod, which caused a panic if that wasn't the case.
In this commit we resolve the UUID to check if the pod actually exists.
Also, make rm's behavior consistent between caling it with a pod UUID
and with
--uuid-file:There's no tests for
rkt rm. I add some in #2655. I can add a test-case for this there.Fixes #2678