rkt-monitor: bunch of improvements #3093
Conversation
mzylowski
force-pushed
the
mzylowski/rkt-benchmarking
branch
from
f760376
to
c500f7a
Compare
|
Looks like gofmt is failing.. |
mzylowski
force-pushed
the
mzylowski/rkt-benchmarking
branch
from
c500f7a
to
e5d4af6
Compare
|
Ehh.. My stupid IDE. Rebased. |
mzylowski
force-pushed
the
mzylowski/rkt-benchmarking
branch
from
e5d4af6
to
2ecf09f
Compare
| acbuild --debug copy build-rkt-1.13.0+git/target/bin/"${1}"-stresser /worker | ||
| acbuild --debug set-exec -- /worker | ||
| acbuild --debug write --overwrite "${1}"-stresser.aci | ||
| acbuildEnd |
There was a problem hiding this comment.
don't you still need to trap this in case one of the acbuild steps fails?
There was a problem hiding this comment.
My idea was to use acbuildEnd instead of trap.
In my function we looking for acbuild directory. If it exist we can finish old build by acbuild --debug end. So if there was any unfinished job before running the script we end it immediately and safe build our images.
Did I miss something in my solution? ;]
There was a problem hiding this comment.
The set -e makes the script exit when an acbuild command fails, and the trap makes the script run acbuild end when the script is about to exit. This means in the event of an error acbuild is able to clean up after itself.
Removing the trap will prevent the script from performing cleanup on error, so I'd highly recommend putting that back.
mzylowski
force-pushed
the
mzylowski/rkt-benchmarking
branch
from
2ecf09f
to
91cba1d
Compare
|
I see a new commit was pushed, but some of my comments still stand :-) |
mzylowski
force-pushed
the
mzylowski/rkt-benchmarking
branch
from
91cba1d
to
b016af1
Compare
|
There was some work in progress (it is way there was an extra commit). We probably discover new issue related with lkvm and memory test, but it still need to be investigate. For now I added output message if something goes wrong with stopping the container. |
mzylowski
force-pushed
the
mzylowski/rkt-benchmarking
branch
3 times, most recently
from
3ea985d
to
69cd58d
Compare
|
punting to @dgonyeo when he's available |
|
@iaguis Maybe you also are interested ? |
| func main() { | ||
| fmt.Print("APP-STARTED!\n") |
There was a problem hiding this comment.
Oh, and after reading more of this PR it is. Nevermind.
|
Great work! Had a couple comments, other than those LGTM. |
mzylowski
force-pushed
the
mzylowski/rkt-benchmarking
branch
from
69cd58d
to
6c6b81f
Compare
|
@dgonyeo Suggestions are applied now ;] |
mzylowski
force-pushed
the
mzylowski/rkt-benchmarking
branch
2 times, most recently
from
dfae1c2
to
313071d
Compare
|
Well |
|
@mzylowski this needs a refresh to land, can you please rebase against master? |
* Container start time is measured by reading output from app * Using rkt stop instead of killing all processes * Using rkt gc when container is in exit state * Using milliseconds instead of nanoseconds * Added test image name to output csv filename * Option for build all test images by one command * Readme updated * Minor fixes
mzylowski
force-pushed
the
mzylowski/rkt-benchmarking
branch
from
313071d
to
367b414
Compare
|
@lucab Done ;] |
In the context of #3019