This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
Fix creation of HardLinks. #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sgotti awesome, thanks for the patch! LGTM. |
jonboulle
added a commit
that referenced
this pull request
Dec 4, 2014
pkg/tar: fix creation of HardLinks.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. Congrats for great work!
I was trying to manually create a fileset for a base fedora image using gnu tar. On rkt run I noticed that it was failing extracting the tar with an error like this:
run: error setting up stage0: error setting up image sha256-5d12db67edc3884bf0a659390f162d83dedcadfbc8cdf96a82650adbdd871705: error extracting ACI: link ./rootfs/usr/bin/pkg-config /var/lib/rkt/containers/d1c6e082-686a-4e97-88c4-2f1df432b307/stage1/opt/stage2/sha256-5d12db67edc3884bf0a659390f162d83dedcadfbc8cdf96a82650adbdd871705/rootfs/usr/bin/x86_64-redhat-linux-gnu-pkg-config: no such file or directoryWith tar the LinkName of an hardlink is different from the one of a symlink. It's the path relative to the tar's root.
I tried to fix it.
I also fixed the security check (if something malicious creates a tar with a bad Linkname like ../../../etc/shadow)
I have some doubts (maybe a new issue will be better) on the check for the symlinks as a symlink can also be an absolute path (it's now working as the abs path is joined with the dest file dir).
Thanks!