Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support deployment garbage collection based on versions #1905

Open
jlebon opened this issue Sep 18, 2019 · 1 comment
Open

Support deployment garbage collection based on versions #1905

jlebon opened this issue Sep 18, 2019 · 1 comment

Comments

@jlebon
Copy link
Member

jlebon commented Sep 18, 2019

This came up in ostreedev/ostree#1922. Essentially, the idea is to make garbage collection smarter by always keeping at least the last two versions of deployments. This prevents repeated layered commits (from e.g. rpm-ostree install commands) from flushing out the previous version's deployment.

The rationale is that for e.g. Silverblue/FCOS systems, the version string is associated with a specific snapshot of Fedora content. So in general, they're more meaningful deltas in terms of fallback than local recomposes from install operations.

@jlebon
Copy link
Member Author

jlebon commented Oct 11, 2019

I filed this here, but I think most of the work for this would take place in libostree. E.g. have a new OstreeSysrootSimpleWriteDeploymentFlags flag like OSTREE_SYSROOT_SIMPLE_WRITE_DEPLOYMENT_FLAGS_RETAIN_PREVIOUS_VERSION? Though offhand, looks like at least this TODO would have to be addressed so that the staging path (which is the default now) can pass that flag along.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant