-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nightly builds #2034
Comments
Hey @lifeforms , I've been playing a bit with this. Take a look at https://github.com/fzipi/coreruleset/releases. There you have some of the options that can be done automatically. My conclusion is that, unless we create a github action ourselves, the ones have limited support. In summary:
Let me know what you think. |
Thank you for looking into this @fzipi. I am not quite sure I follow you. So you think the existing functionality you demonstrated at the URI linked is overly limited and you propose we write our own action. Questions:
Personally, I could live with the |
Well, we can get the files, but we will always get the additional zip and targz files of the commits in master. So my vote will be for just publishing what we have in master for nightly. We can write our own github action, of course, but need to review the API to see if we can do a release that doesn't include the default files or something like that. This will take additional time. |
Hold on, when we do the nightly builds as you propose, we get a new commit with a zip blob every night? Still not understanding this properly. How much time for the basic setup you propose? |
You get one nightly every day, yes. The basic setup, 5-10 minutes, and one merge. |
An automatic commit with an update to an file in the main branch every night is a no-go, I think. |
Let's try again. I'm not explaining myself correctly 😄
|
OK. Thank you. Sounds much better than what I misunderstood. But the nightly builds always have the same name / file names and they will clog the release / tags view with a new entry every day? If not, it's a no-brainer, I think. Running with a stable file name for nightly builds seems pretty standard for me. |
Yes, they will overwrite the last one. I think you can have the last X releases around, but need to double check. For me, this will be an way for downstream providers to have a quick curl and script their tests, instead of waiting for a release. But they can do the same using just git. It is just "nice to have". |
Do you have a status update here @fzipi? |
Yes @dune73. Added PR and can be merged anytime. |
Motivation
Right now, a person reports a FP, we fix it quickly, but it might take 6 months for the PR to become generally available in an easily downloadable zip.
Users could track our github but it is a more geeky action and it is discongruent with their normal integration process of using our zips.
Maybe even downstream users won't like our release schedule and they would prefer to make their CRS cuts at a different point in time than our releases (see Ubuntu versus Debian).
In general, our development branch is pretty stable, and these days we find relatively few blocking issues during RC testing.
Proposed solution
We should look into issuing nightly zip builds and publish those on our website.
People who have a successfully solved issue can quickly download an updated zip with their fix. (They should still carefully study the CHANGES file though, because we could have introduced backward incompatible changes in the meantime!)
Code changes to consider in the zip:
Ideally this would be done with a msc_parser script.
Alternatives
Keep using Github for pre-releases and direct people to use our Git contents instead of zip files, as we do now.
Additional context
Github Actions support cron actions so we could generate a zip file daily and put this on the website. It will involve quite some advanced Github Action mastery, so we shouldn't expect it too soon.
The text was updated successfully, but these errors were encountered: