Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

side menu items in RTL should stick to right #31

Closed
ahmadalli opened this issue Nov 13, 2017 · 3 comments
Closed

side menu items in RTL should stick to right #31

ahmadalli opened this issue Nov 13, 2017 · 3 comments

Comments

@ahmadalli
Copy link

Hi.

Thank you for this great theme.

when I set dir="rtl"

image

this happens in sidemenu:

image

while it's ok in ltr mode:

image

the problems are

  • items must stick to right (right now they're overlapping arrow icon in items with submenu)
  • sidebar minimizer arrow should point and stick to other direction
@ahmadalli
Copy link
Author

I've fixed the menu item issue. this is my _rtl.scss diff:

diff --git a/src/scss/core/_rtl.scss b/src/scss/core/_rtl.scss
index 28db385..f432df1 100644
--- a/src/scss/core/_rtl.scss
+++ b/src/scss/core/_rtl.scss
@@ -134,6 +134,7 @@
         .nav-item {
           .nav-link {
             direction: rtl;
+            text-align: right;
             i {
               margin: 0 0 0 ($sidebar-nav-link-padding-x / 2);
             }

@ahmadalli
Copy link
Author

ahmadalli commented Feb 5, 2018

I finally fixed both problems. but I don't know where to send PR. Will you apply the PR (if accepted) to other core-ui repositories too? @mrholek

@xidedix
Copy link
Member

xidedix commented Mar 29, 2019

Please update to the latest version to @coreui/coreui

I'm closing this since it appears to be inactive and no longer valid.
Please comment and/or reopen if you feel the issue has not been resolved.

@xidedix xidedix closed this as completed Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants