Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar Minimizer doesn't adjust to height and hides available side menu items #29

Closed
jflayhart opened this issue Nov 15, 2017 · 3 comments

Comments

@jflayhart
Copy link

jflayhart commented Nov 15, 2017

First off, even though this is a complaint, I really love this theme! It's saved me alot of time on the UI.

The issue is minimizing the sidebar (not hide it) and shrinking the height of the browser viewport causes the minimize arrow to lose "responsiveness" to the point where it is no longer visible to restore the sidebar to its maximized state. Furthermore, under a certain height you cannot scroll to view other menu items (minimized state only).

This is quite disruptive because some mobile devices cannot function properly and delivers frustrating UX. I've tried looking into the cause but not entirely sure what's going on... running version 1.0.5 of CoreUI.

The expected behavior, at least for me, would be to have the minimize arrow ALWAYS on the bottom, and then the overflowY set to scroll, so you can still view all the nav items as you would in the maximized view.

Minimized:
minimized

Shrink Browser Height (now minimizer icon is gone and have to make browser even taller than before to view minimize button):
reduce_height-no-min-icon

Cuts off other menu items, no scroll:
reduce_height-cuttoff-menu-item-and-minimize-icon

@marchershey
Copy link

  1. Open '_sidebar.scss'
  2. Navigate to Line 79 - Should look like this:
.nav {
  @include sidebar-width($sidebar-borders, $sidebar-width);
  flex-direction: column;
  min-height: 100%;
}
  1. Change min-height: 100% to min-height: calc(100% - 55px);
  2. Should look like this once done:
.nav {
  @include sidebar-width($sidebar-borders, $sidebar-width);
  flex-direction: column;
  min-height: calc(100% - 55px);
}

I had this same issue, so once I resolved it I thought it would be a good idea to help anyone else having the same issue. Hope it helped. If you have any questions, let me know.

@hirocsingh
Copy link

Actually that didn't work for me. If there is any other way ? @marchershey

@woothu
Copy link
Contributor

woothu commented Jun 25, 2020

This issue is fixed in v3 of the CoreUI

@woothu woothu closed this as completed Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants