Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance #324

Closed
edwinkortman opened this issue Oct 10, 2022 · 3 comments
Closed

Performance #324

edwinkortman opened this issue Oct 10, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@edwinkortman
Copy link
Contributor

edwinkortman commented Oct 10, 2022

Due to performance issues, tests in CI are failing because they are hitting the time-out.
e.g. #310

We also noticed that when running the analysis on a small repository, it'll take longer than we want to (+1 minute easily).

This issue exists to collect data on our current performance state.

@edwinkortman edwinkortman self-assigned this Oct 10, 2022
@edwinkortman edwinkortman added the enhancement New feature or request label Oct 10, 2022
@edwinkortman
Copy link
Contributor Author

edwinkortman commented Oct 10, 2022

Analyzing fixture repository

Command: freshli analyze https://github.com/corgibytes/freshli-fixture-java-test
Total time running: 1m 56s

Image
image

  • Corgibytes.Freshli.Cli.Functionality.Environment.GetListOfFiles throws 168 exceptions
  • Corgibytes.Freshli.Cli.Functionality.Environment.GetListOfFiles allocates 119 MB

image

  • 27.3% of the total time is spent on Corgibytes.Freshli.Cli.Functionality.Invoke.Command

@edwinkortman edwinkortman mentioned this issue Oct 10, 2022
@edwinkortman
Copy link
Contributor Author

Adding caching

Caching was added in this PR: #325
If the PR is merged & approved, the Package results are saved to the database saving us from calling the agent multiple times for the same package.

Command: freshli analyze https://github.com/corgibytes/freshli-fixture-java-test
Total time running: 1m 21s (before 1m 56s)

@edwinkortman
Copy link
Contributor Author

With these PRs added, I think it's best to revisit this issue once we got those implemented. The main culprits I could identify were calls to the agent.

corgibytes/freshli-agent-java#34
corgibytes/dependency-history-maven#24

@mscottford mscottford added this to the v0.5.0 milestone Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

2 participants