Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are you happy to add me as a contributor to fox the library? #664

Open
acb122 opened this issue May 17, 2021 · 3 comments
Open

Are you happy to add me as a contributor to fox the library? #664

acb122 opened this issue May 17, 2021 · 3 comments

Comments

@acb122
Copy link

acb122 commented May 17, 2021

We use this library internally and currently have branches off of yours to put fixes in. I’d like to contribute back to your repo and keep this library alive.

@cormacrelf
Copy link
Owner

I'd really appreciate that, I think others would as well. I've not used Angular in years, and then all at once a while back both the dnd project and Angular had like 15 total breaking changes affecting this, and I was like, nope, can't do it, can't keep up with the churn. Sorry to all!

Who's "we"? I think maybe an organisation would work as well. I don't envision a time when I'll be using this again, I don't think it needs my name plastered over it forever.

@acb122
Copy link
Author

acb122 commented May 17, 2021

Great, yes we have fixes up too angular 11 (https://github.com/acb122/skyhook) but with the most recent Angular release 12.0 we are making more changes and thought it would be worth while reaching out to you as the core DND module points to your solution for Angular so would be great for the community to benefit from your's and our work.

I work for Goldman Sachs, I can raise it to see if we would like to take it on as an official contributor to the library but that will take time. Maybe the best way forward for now would be if your happy to allowing me access to contribute to this Repo and also to have privileges to push new packages to NPM.

@rmcsharry
Copy link

@cormacrelf and @acb122 any progress on this?

It seems like a great idea to me, but 7 months have passed...hopefully it's not an opportunity missed...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants