Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The water reward is destructive #90

Open
kneekoo opened this issue Mar 29, 2024 · 2 comments
Open

The water reward is destructive #90

kneekoo opened this issue Mar 29, 2024 · 2 comments

Comments

@kneekoo
Copy link

kneekoo commented Mar 29, 2024

While working on expanding my platform and grass, I avoided covering the dirt with anything, so I can get more flowers and grasses. As a result, I used the "quest block" to place stuff around it. On top, I placed my chest with rewards and other items. Once I completed the quest rewarding water, my chest was replaced with a water source block, thus losing the chest with everything inside. 🤦‍♂️

screenshot_20240329_111030

The little luck I can claim about this situation is that:

  • I didn't lose any vegetation on my lawn when the water covered most of my island
  • it warned me that if lava is also rewarded like that, things can get a lot worse

Please consider exclusively adding the rewards in the reward slots. That way you don't have to check if the user placed stuff where the reward would be placed in the world to avoid loss. Alternatively, you could either disallow the placement of items above the quest block, or at least warn us that placing anything on top can lead to losing that block. Anyway, since I'm new to this modpack I don't know if there are other positions around the quest block that get replace with rewards. So now I have to be extra cautious.

@cornernote
Copy link
Owner

hello @kneekoo , thank you for creating issues. They do seem like valid problems.

I have not worked on minetest for many years, and this project is now very old and far back in my memory. If you'd like to do some PRs i'd be happy to review and accept them.

@kneekoo
Copy link
Author

kneekoo commented Apr 14, 2024

Thanks for your reply. I haven't done much with Minetest other than a tiny mod, so I'm not sure I can help. But I'm glad you're open for contributions. Hopefully someone with both the knowledge and willingness to polish the rough edges will turn up. :) It's a nice game, worth having around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants