Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't reset display pipeline when spacing is missing #301

Conversation

bionoone
Copy link
Contributor

@bionoone bionoone commented Nov 17, 2022

handle the case when image has no pixel spacing and image data use default spacing.

@netlify
Copy link

netlify bot commented Nov 17, 2022

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit f98045c
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/6376557472350900096b4594
😎 Deploy Preview https://deploy-preview-301--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bionoone bionoone force-pushed the fix/stackViewport-reset-when-missing-spacing branch from d3d3a5e to f98045c Compare November 17, 2022 15:38
Copy link
Member

@sedghi sedghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thanks

@sedghi sedghi merged commit e12fcf3 into cornerstonejs:main Nov 19, 2022
NeilMacPhee pushed a commit to NeilMacPhee/cornerstone3D-beta that referenced this pull request Nov 22, 2022
wayfarer3130 pushed a commit that referenced this pull request Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants