Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VolumeViewport): added null actorEntry check in VolumeViewport.getCurrentImageId #618

Merged

Conversation

jbocce
Copy link
Contributor

@jbocce jbocce commented May 18, 2023

Context

The was a null exception thrown in VolumeViewport.getCurrentImageId when no actor entry was present.

Changes & Results

Added a null check.

Testing

Attempt to call VolumeViewport.getCurrentImageId right after the viewport element is enabled. It should not throw and exception.

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

Public Documentation Updates

  • The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • OS: Windows 11
  • Node version: 19.18.1
  • Browser: Chrome 113.0.5672.127

@netlify
Copy link

netlify bot commented May 18, 2023

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit 28f157d
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/64665eae985f8400087039aa
😎 Deploy Preview https://deploy-preview-618--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jbocce jbocce requested a review from sedghi May 18, 2023 17:21
@sedghi sedghi merged commit e5fd29b into cornerstonejs:main May 18, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants