fix(DicomImageLoader): Returns options.loader #1154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
wayfarer3130
pushed a commit
that referenced
this pull request
Apr 8, 2024
sedghi
pushed a commit
that referenced
this pull request
Apr 9, 2024
* chore(beta): release beta for v2 * chore(beta): release beta for v2 (#715) * chore(beta): release beta for v2 again (#716) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(camera initial zoom): make the image fit the canvas for initial reset * fix: Render to pixel exact positioning, and add a zoom setting * api-check * PR updates - mostly docs and some cleanup * fix: Offset positions sometimes render moire patterns * fix: Fractional positioning for center point * Fix the center offset * PR review comments * API check * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(structuredClone): drop lodash.clonedeep in favor of structuredClone (#517) * drop lodash.clonedeep in favor of structuredClone * copy svgNodeCache outside structured clone when resetting state * remove clonedeep leftovers * api --------- * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * api * new stack images * Revert changes * Add synchronizer and test configuration for scale * Fix positioning * fix zoom * Fix pan for scale to fit * Fixes for resize * Changes to make tests pass again * Fix scale display * Fixes for resize viewport * Fix centering/positioning without needing initial camera setting * Fix resize issues with rotation * Cleanup for build * Add todo for fuzzy fit to viewport scaling issue * Cleanup of types/values * fix: render annotations without plane normal on viewports and update default svg colors (#1159) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(cine): playclip to allow loop config (#1163) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(DicomImageLoader): Returns options.loader (#1154) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * docs: Update getAnnotation Api (#1169) annotations' S word should be removed and getAnnotations method parameters are written in reverse order * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * examples: Add better helper method for adding tools dropdown (#1150) * test: Add better helper method for adding tools dropdown. * Add stack annotation example * Add labelmap tools as well * Add contour tools import as well. * PR review comment fixes * api-check * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * Make the size work for positioning * Fix ES6 change * update * Add color utility module to core package * Add color utility module to core package * revert structured clone * Fix cloning of lastSliceAnnotation in ContourInterpolation_test.js * Fix lodash import in addSegmentations.ts * PR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
#990 (comment)
Changes & Results
Testing
Checklist
PR
semantic-release format and guidelines.
Code
[] My code has been well-documented (function documentation, inline comments,
etc.)
[] I have run the
yarn build:update-apito update the API documentation, and havecommitted the changes to this PR. (Read more here https://www.cornerstonejs.org/docs/contribute/update-api)
Public Documentation Updates
additions or removals.
Tested Environment