Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Wrong touch behavior with annotation tools #1168

Open
makinox opened this issue Mar 22, 2024 · 0 comments
Open

[Bug] Wrong touch behavior with annotation tools #1168

makinox opened this issue Mar 22, 2024 · 0 comments

Comments

@makinox
Copy link

makinox commented Mar 22, 2024

Describe the Bug

In the example page stackManipulationToolsTouch, changing the default tool, WindowLevelTool for an annotation tool like LengthTool doesn't work as mentioned in the docs.
For example, in this example page it explains that each tool separated by gestures with one or two or three fingers should work correctly, and it does, but only with the WindowLevelTool, if I replace this tool with LengthTool it works only occasionally.
Here is an example video, trying to zoom with two fingers.

RPReplay_Final1711134835.MP4

My investigation leads me to sometimes the system only captures one finger when i physically put two fingers and then when I start to drag the system recognizes my two fingers, but it doesn't work because the system already started the LengthTool process, here is an image when I'm testing this described behavior.

Screenshot 2024-03-22 at 2 27 39 PM

I'm working on figuring out how to fix this and open for you a pr with the solution, but if you know where I should be looking, it would be great.

Steps to Reproduce

  • open the example page stackManipulationToolsTouch
  • replace WindowLevelTool for LengthTool
  • start the example yarn example stackmanipulationtoolstouch
  • try to drag with two fingers in any phone or tablet

The current behavior

Currently, when it's active an annotation tool with one (finger / click) and it's active a (move / zoom) tool with two fingers, the two fingers behavior only works occasionally.

The expected behavior

To work as described in the docs, different tools separated by (gestures / numTouchPoints) should work fine always, not occasionally.

OS

Any os

Node version

18.16.0

Browser

Any browser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant