Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(getColormap): add opacity mapping to findMatchingColormap return object #1240

Merged
merged 1 commit into from May 9, 2024

Conversation

Sofien-Sellami
Copy link
Contributor

Context

The getProperties function currently returns the colormap name, but it does not include the opacity.

Screenshot from 2024-05-09 10-54-58

Changes & Results

  • Added the opacity mapping to the findMatchingColormap function's return object.
  • The function now returns an object that conforms to the ColormapPublic type, including the name and opacity properties.

Testing

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

Public Documentation Updates

  • The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • "OS:
  • "Node version:
  • "Browser:

Copy link

netlify bot commented May 9, 2024

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit c3c7bd4
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/663c9e16c2d52100082eab7a
😎 Deploy Preview https://deploy-preview-1240--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sedghi sedghi merged commit 16dd89e into cornerstonejs:main May 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants