Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Basic video tool demo #1089

Closed
sedghi opened this issue Feb 14, 2024 · 0 comments · Fixed by #1108
Closed

[Bug] Basic video tool demo #1089

sedghi opened this issue Feb 14, 2024 · 0 comments · Fixed by #1108
Assignees
@wayfarer3130
Labels
Phase 2 Bug fix

Comments

@sedghi
Copy link
Member

sedghi commented Feb 14, 2024 •
edited
Loading

Describe the Bug

https://www.cornerstonejs.org/live-examples/videotools

and

https://www.cornerstonejs.org/live-examples/videorange

Steps to Reproduce

Delete annotation does nothing

The current behavior

  1. Key image needs a click
  2. The video starts playing like couple of seconds and then it pauses
  3. What is Current Image

The expected behavior

Also we should be able to programmatically add the keyimage, right now it seems like we have to click on the image, a utility would be nice to have (pretty sure is a must)

If the video should start from pause it should play

I still don't understand the use of current image really. Can you explain that in the instructions? what is the difference between current image and start range and end range

OS

d

Node version

d

Browser

d
wayfarer3130 added a commit that referenced this issue Feb 20, 2024
@wayfarer3130
fix: Video issues in the demo ([#1089]) delete, play, current image
bb1bda2
@wayfarer3130 wayfarer3130 mentioned this issue Feb 20, 2024
Merged
sedghi pushed a commit that referenced this issue Feb 21, 2024
@wayfarer3130
fix: Video issues in the demo delete, play, current image (#1108)
c8a7a89 
* fix: Video issues in the demo ([#1089]) delete, play, current image

* Change the video size for segmentation to match underlying size

* fix: Shadow in rendering labelmap overlay

* PR comments

* PR comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wayfarer3130 wayfarer3130

Labels
Phase 2 Bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Video issues in the demo delete, play, current image cornerstonejs/cornerstone3D
2 participants
@sedghi @wayfarer3130