-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Warning for WSIViewport.js: Critical dependency: the request of a dependency is an expression #1328
Comments
me too same problem |
are you using vite? i will fix this in the 2.x version |
No, we use webpack. |
I am using Webpack and facing same issue. |
What are you doing that it comes out as an error? The webpack builds that I'm working with all show it as a warning, not an error: Try adding to the webpack Also, you may not be able to build/run with Webpack 5.92.0 - try forcing it on 5.89.0 as there is a bug in 5.90 and later causing static values to be not compiled properly. |
Hi, Other points
Note, the warning still persists in the console
|
It seems to be resolved. Using v1.82.0 |
Describe the Bug
Hi,
I get the following warning when running @cornerstone/core (1.78.0) on a local machine with node.
Also, check image below.
![image](https://private-user-images.githubusercontent.com/2803936/339849188-c0057b1a-a8e0-4d56-ac3a-ed295bd60c9e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE0MDg0OTEsIm5iZiI6MTcyMTQwODE5MSwicGF0aCI6Ii8yODAzOTM2LzMzOTg0OTE4OC1jMDA1N2IxYS1hOGUwLTRkNTYtYWMzYS1lZDI5NWJkNjBjOWUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcxOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MTlUMTY1NjMxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ODk4MmY1YWViNTZiMjkxNmM3OTNmMmVjZWU4MTFiYTk2YzU4MzUxNzU0YjYyN2I5OTViOWUzNGE0NjM1YzNlYSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.KdoMH77TBuLfcbJeYdd9-LJb7u1gFY0taL050Wc0J54)
And the line 274 from
![image](https://private-user-images.githubusercontent.com/2803936/339854647-0859a456-bb79-4235-a164-2255c356eae6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE0MDg0OTEsIm5iZiI6MTcyMTQwODE5MSwicGF0aCI6Ii8yODAzOTM2LzMzOTg1NDY0Ny0wODU5YTQ1Ni1iYjc5LTQyMzUtYTE2NC0yMjU1YzM1NmVhZTYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcxOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MTlUMTY1NjMxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9N2ZkODgxNTM5M2YzM2U1ZTgzNmExY2RhZjBjZTVlM2Y0YzFiYmIwMDc0MGU0ODM5OWQ2ZTBkOGM4ZjkzZThkZCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.gaq1lzcRtn62FIzrzEkRFFVljefFetbkvSd4vEtp5wE)
@cornerstonejs/core/dist/esm/RenderingEngine/WSIViewport.js
Although this does not block my script from running, it is quite annoying (I need to keep hitting the cross on the top-right everytime).
I did not see find any reference to this on the cornerstone3D repo's issues tab. Maybe this is something worth looking into.
Steps to Reproduce
To reproduce one can use the
package.json
andwebpack.config.js
below:npx webpack --mode development
npm start
The current behavior
I get a warning from
WSIViewport.js
saying:Critical dependency: the request of a dependency is an expression
The expected behavior
The warning in
WSIViewport.js
should not show up. I also tried this on a jsfiddle, but it did not show the warning.OS
macOS 14.2
Node version
20.8.0
Browser
Brave Browser (v 1.65.126)
The text was updated successfully, but these errors were encountered: